[PR #1009] [MERGED] Add tests for KeySequence #1736

New issue

Closed

opened 2026-05-05 08:00:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1009
Author: @p12tic
Created: 1/7/2021
Status: ✅ Merged
Merged: 1/7/2021
Merged by: @p12tic

Base: master ← Head: gui-keysequence-tests

📝 Commits (7)

6b31735 gui: List all source files explicitly for the lupdate tool
1d5fcfa gui: Remove qmake project
01b97d0 gui: Explicitly set the lists of source files
acc54de src: Extract test CMake setup to separate file
3f387bd gui: Fix incorrect parameter order in KeySequence::appendKey()
1c434df gui: Remove unnecessary accessor to private member in KeySequence
88c0c03 gui: Add tests for KeySequence serialization

📊 Changes

10 files changed (+297 additions, -181 deletions)

View changed files

📝 CMakeLists.txt (+3 -0)
📝 cmake/gtest.cmake (+6 -9)
📝 src/CMakeLists.txt (+4 -1)
📝 src/gui/CMakeLists.txt (+129 -2)
➖ src/gui/gui.pro (+0 -162)
📝 src/gui/lang.cmd (+1 -1)
📝 src/gui/src/KeySequence.cpp (+4 -4)
📝 src/gui/src/KeySequence.h (+1 -2)
➕ src/gui/test/KeySequenceTests.cpp (+126 -0)
➕ src/gui/test/main.cpp (+23 -0)

📄 Description

This setups a way to write unit tests for the gui sub-project. The first set of tests are for the KeySequence serialization in an attempt to add tests for #916. However, it seems that at least I didn't understand the issue correctly and tests didn't reproduce failure as expected, so the problem is one layer higher.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1009 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 1/7/2021 **Status:** ✅ Merged **Merged:** 1/7/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `gui-keysequence-tests` --- ### 📝 Commits (7) - [`6b31735`](https://github.com/debauchee/barrier/commit/6b317359ba90fcc19ccbc52e412e87a6e16bbe80) gui: List all source files explicitly for the lupdate tool - [`1d5fcfa`](https://github.com/debauchee/barrier/commit/1d5fcfa3af7cbfb6a466faea068055461b972b8e) gui: Remove qmake project - [`01b97d0`](https://github.com/debauchee/barrier/commit/01b97d0c2a99dd4c1f6835cd85007b124db47d7b) gui: Explicitly set the lists of source files - [`acc54de`](https://github.com/debauchee/barrier/commit/acc54de922939b0f2a2659966f07b6385a9bf598) src: Extract test CMake setup to separate file - [`3f387bd`](https://github.com/debauchee/barrier/commit/3f387bdad0ed843486d97b8b94da6fcc13021171) gui: Fix incorrect parameter order in KeySequence::appendKey() - [`1c434df`](https://github.com/debauchee/barrier/commit/1c434df87a1da74869e27ea3f7e85e545f50f981) gui: Remove unnecessary accessor to private member in KeySequence - [`88c0c03`](https://github.com/debauchee/barrier/commit/88c0c030f8e4cc8583e7012fd32e5ed08dfc505f) gui: Add tests for KeySequence serialization ### 📊 Changes **10 files changed** (+297 additions, -181 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+3 -0) 📝 `cmake/gtest.cmake` (+6 -9) 📝 `src/CMakeLists.txt` (+4 -1) 📝 `src/gui/CMakeLists.txt` (+129 -2) ➖ `src/gui/gui.pro` (+0 -162) 📝 `src/gui/lang.cmd` (+1 -1) 📝 `src/gui/src/KeySequence.cpp` (+4 -4) 📝 `src/gui/src/KeySequence.h` (+1 -2) ➕ `src/gui/test/KeySequenceTests.cpp` (+126 -0) ➕ `src/gui/test/main.cpp` (+23 -0) </details> ### 📄 Description This setups a way to write unit tests for the gui sub-project. The first set of tests are for the KeySequence serialization in an attempt to add tests for #916. However, it seems that at least I didn't understand the issue correctly and tests didn't reproduce failure as expected, so the problem is one layer higher. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>