[PR #988] [MERGED] Perform clean uninstall on windows #1733

New issue

Closed

opened 2026-05-05 08:00:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/988
Author: @albertony
Created: 12/11/2020
Status: ✅ Merged
Merged: 12/29/2020
Merged by: @p12tic

Base: master ← Head: win_clean_uninstall

📝 Commits (2)

91baa4f Perform clean uninstall on windows
2c5cdf1 Add version info resource to windows setup exe

📊 Changes

1 file changed (+17 additions, -7 deletions)

View changed files

📝 dist/inno/barrier.iss.in (+17 -7)

📄 Description

Changes:

Killing the main application process (with any children) before uninstalling.
- Existing version will just leave it running and uninstall whatever it is able to, which is then not much, leaving a behind most program files.
- Alternative could be to abort the uninstall if application is running, but don't think that is necessary(?)
Using net stop instead of sc stop for stopping the service before uninstalling it.
- Because sc stop will run completely async and then the following sc delete typically fails because it is still running, leaving barrierd.exe behind after uninstall.
- net stop will automatically wait until it has stopped, but will not block forever - aborts with error if service is unresponsive or takes more than 30 seconds.
Delete C:\ProgramData\Barrier, containing barrierd.log, on uninstall.
- Existing installer had statement for deleting barrierd.log i application folder, but this is not (no longer) where the log file is created.
Show application icon in entry in "Programs and Features" control panel.

Will still leave registry settings and user configuration in %LocalAppData%\Barrier folder (server config file, certificates and fingerprints) behind, I guess this is the sort of user-specific settings that are expected to be left behind in case of reinstall..

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/988 **Author:** [@albertony](https://github.com/albertony) **Created:** 12/11/2020 **Status:** ✅ Merged **Merged:** 12/29/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `win_clean_uninstall` --- ### 📝 Commits (2) - [`91baa4f`](https://github.com/debauchee/barrier/commit/91baa4f133a4a6beb5ea71566d51f166ee96935b) Perform clean uninstall on windows - [`2c5cdf1`](https://github.com/debauchee/barrier/commit/2c5cdf1037177885a986750bb9b304f981031aa8) Add version info resource to windows setup exe ### 📊 Changes **1 file changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `dist/inno/barrier.iss.in` (+17 -7) </details> ### 📄 Description Changes: 1) Killing the main application process (with any children) before uninstalling. - Existing version will just leave it running and uninstall whatever it is able to, which is then not much, leaving a behind most program files. - Alternative could be to abort the uninstall if application is running, but don't think that is necessary(?) 2) Using `net stop` instead of `sc stop` for stopping the service before uninstalling it. - Because `sc stop` will run completely async and then the following `sc delete` typically fails because it is still running, leaving `barrierd.exe` behind after uninstall. - `net stop` will automatically wait until it has stopped, but will not block forever - aborts with error if service is unresponsive or takes more than 30 seconds. 3) Delete `C:\ProgramData\Barrier`, containing `barrierd.log`, on uninstall. - Existing installer had statement for deleting `barrierd.log` i application folder, but this is not (no longer) where the log file is created. 4) Show application icon in entry in "Programs and Features" control panel. Will still leave registry settings and user configuration in `%LocalAppData%\Barrier` folder (server config file, certificates and fingerprints) behind, I guess this is the sort of user-specific settings that are expected to be left behind in case of reinstall.. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>