[PR #979] [MERGED] Use ansi codepage for internal multibyte strings on windows (fixes #976, fixes #974, fixes #444) #1727

New issue

Closed

opened 2026-05-05 08:00:26 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:26 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/979
Author: @albertony
Created: 12/9/2020
Status: ✅ Merged
Merged: 12/30/2020
Merged by: @p12tic

Base: master ← Head: cp_acp

📝 Commits (1)

402801e Use ansi codepage for internal multibyte strings on windows (fixes #976, fixes #974, fixes #444)

📊 Changes

14 files changed (+151 additions, -86 deletions)

View changed files

📝 src/gui/src/CommandProcess.cpp (+11 -10)
📝 src/gui/src/Fingerprint.cpp (+2 -5)
📝 src/gui/src/IpcClient.cpp (+3 -5)
📝 src/gui/src/MainWindow.cpp (+1 -2)
📝 src/gui/src/QUtility.cpp (+9 -0)
📝 src/gui/src/QUtility.h (+1 -0)
📝 src/gui/src/SslCertificate.cpp (+21 -26)
📝 src/gui/src/SslCertificate.h (+4 -4)
📝 src/lib/barrier/win32/DaemonApp.cpp (+2 -1)
📝 src/lib/common/win32/DataDirectories.cpp (+3 -25)
➕ src/lib/common/win32/KnownFolderPaths.cpp (+63 -0)
➕ src/lib/common/win32/KnownFolderPaths.h (+24 -0)
📝 src/lib/ipc/IpcLogOutputter.cpp (+2 -1)
📝 src/lib/platform/MSWindowsScreen.cpp (+5 -7)

📄 Description

Fixes https://github.com/debauchee/barrier/issues/976
Fixes https://github.com/debauchee/barrier/issues/974
Fixes https://github.com/debauchee/barrier/issues/444

Probably conflicts with https://github.com/debauchee/barrier/pull/972, but if you accept both PRs then just "ping" me and I can quickly fix it (either if I can merge the PR branches together, or you can merge one of them to master first and I rebase the other one, or something else..?)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/979 **Author:** [@albertony](https://github.com/albertony) **Created:** 12/9/2020 **Status:** ✅ Merged **Merged:** 12/30/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `cp_acp` --- ### 📝 Commits (1) - [`402801e`](https://github.com/debauchee/barrier/commit/402801e0a66a902475723c13f3a03bac2b7fd503) Use ansi codepage for internal multibyte strings on windows (fixes #976, fixes #974, fixes #444) ### 📊 Changes **14 files changed** (+151 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/src/CommandProcess.cpp` (+11 -10) 📝 `src/gui/src/Fingerprint.cpp` (+2 -5) 📝 `src/gui/src/IpcClient.cpp` (+3 -5) 📝 `src/gui/src/MainWindow.cpp` (+1 -2) 📝 `src/gui/src/QUtility.cpp` (+9 -0) 📝 `src/gui/src/QUtility.h` (+1 -0) 📝 `src/gui/src/SslCertificate.cpp` (+21 -26) 📝 `src/gui/src/SslCertificate.h` (+4 -4) 📝 `src/lib/barrier/win32/DaemonApp.cpp` (+2 -1) 📝 `src/lib/common/win32/DataDirectories.cpp` (+3 -25) ➕ `src/lib/common/win32/KnownFolderPaths.cpp` (+63 -0) ➕ `src/lib/common/win32/KnownFolderPaths.h` (+24 -0) 📝 `src/lib/ipc/IpcLogOutputter.cpp` (+2 -1) 📝 `src/lib/platform/MSWindowsScreen.cpp` (+5 -7) </details> ### 📄 Description Fixes https://github.com/debauchee/barrier/issues/976 Fixes https://github.com/debauchee/barrier/issues/974 Fixes https://github.com/debauchee/barrier/issues/444 Probably conflicts with https://github.com/debauchee/barrier/pull/972, but if you accept both PRs then just "ping" me and I can quickly fix it (either if I can merge the PR branches together, or you can merge one of them to master first and I rebase the other one, or something else..?) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>