[PR #978] [MERGED] Add version info resource to windows exe #1726

New issue

Closed

opened 2026-05-05 08:00:26 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:26 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/978
Author: @albertony
Created: 12/8/2020
Status: ✅ Merged
Merged: 12/9/2020
Merged by: @p12tic

Base: master ← Head: rc_version_info

📝 Commits (3)

5fdb750 Add version info to windows client and server exe resources
aea4881 Cleanup windows client and server exe resource build
366342e Add resource with icon and version info to windows deamon exe

📊 Changes

11 files changed (+249 additions, -69 deletions)

View changed files

📝 cmake/Version.cmake (+3 -0)
📝 src/cmd/barrierc/CMakeLists.txt (+1 -10)
➖ src/cmd/barrierc/barrierc.exe.manifest (+0 -2)
📝 src/cmd/barrierc/barrierc.rc (+63 -34)
📝 src/cmd/barrierd/CMakeLists.txt (+3 -0)
➕ src/cmd/barrierd/barrierd.ico (+0 -0)
➕ src/cmd/barrierd/barrierd.rc (+112 -0)
➕ src/cmd/barrierd/resource.h (+16 -0)
📝 src/cmd/barriers/CMakeLists.txt (+1 -10)
➖ src/cmd/barriers/barriers.exe.manifest (+0 -2)
📝 src/cmd/barriers/barriers.rc (+50 -11)

📄 Description

Server: Same, except (in addition to FileName and OriginalFileName):

FileDescription   : Open source KVM software server

Deamon: Same, except (in addition to FileName and OriginalFileName):

FileDescription   : Open source KVM software deamon

Seems ok? Especially the file description, company name and copyright?

Also included some cleanup of rc builds in barrierc/barriers to make them more in line with recent (that is: newer than ancient!) versions of VC, such as: Removed DISCARDABLE attribute (is ignored when not on 16-bit Windows), removed separate manifest file (is auto generated and embedded since VS2010 or something), removed .ico files from cmake source list (which does nothing there)...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/978 **Author:** [@albertony](https://github.com/albertony) **Created:** 12/8/2020 **Status:** ✅ Merged **Merged:** 12/9/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `rc_version_info` --- ### 📝 Commits (3) - [`5fdb750`](https://github.com/debauchee/barrier/commit/5fdb75092240e4417ed1c2580e448b31173b121a) Add version info to windows client and server exe resources - [`aea4881`](https://github.com/debauchee/barrier/commit/aea488167af19845369e062bf9af4edfadc4fa71) Cleanup windows client and server exe resource build - [`366342e`](https://github.com/debauchee/barrier/commit/366342e4010f3a636e297a9048fea4a9ba705395) Add resource with icon and version info to windows deamon exe ### 📊 Changes **11 files changed** (+249 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `cmake/Version.cmake` (+3 -0) 📝 `src/cmd/barrierc/CMakeLists.txt` (+1 -10) ➖ `src/cmd/barrierc/barrierc.exe.manifest` (+0 -2) 📝 `src/cmd/barrierc/barrierc.rc` (+63 -34) 📝 `src/cmd/barrierd/CMakeLists.txt` (+3 -0) ➕ `src/cmd/barrierd/barrierd.ico` (+0 -0) ➕ `src/cmd/barrierd/barrierd.rc` (+112 -0) ➕ `src/cmd/barrierd/resource.h` (+16 -0) 📝 `src/cmd/barriers/CMakeLists.txt` (+1 -10) ➖ `src/cmd/barriers/barriers.exe.manifest` (+0 -2) 📝 `src/cmd/barriers/barriers.rc` (+50 -11) </details> ### 📄 Description ![Client](https://user-images.githubusercontent.com/12441419/101554339-b943ee00-39b6-11eb-8422-0d56cce77176.png) Server: Same, except (in addition to FileName and OriginalFileName): ``` FileDescription : Open source KVM software server ``` Deamon: Same, except (in addition to FileName and OriginalFileName): ``` FileDescription : Open source KVM software deamon ``` Seems ok? Especially the file description, company name and copyright? Also included some cleanup of rc builds in barrierc/barriers to make them more in line with recent (that is: newer than ancient!) versions of VC, such as: Removed DISCARDABLE attribute (is ignored when not on 16-bit Windows), removed separate manifest file (is auto generated and embedded since VS2010 or something), removed .ico files from cmake source list (which does nothing there)... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>