[PR #846] [MERGED] Add BARRIER_BUILD_TESTS and BARRIER_USE_EXTERNAL_GTEST CMake options #1707

New issue

Closed

opened 2026-05-05 07:59:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/846
Author: @chewi
Created: 8/21/2020
Status: ✅ Merged
Merged: 8/22/2020
Merged by: @p12tic

Base: master ← Head: tests

📝 Commits (3)

4a031b8 Add BARRIER_BUILD_TESTS CMake option to make tests optional
bd1db36 Add BARRIER_USE_EXTERNAL_GTEST CMake option to use external GTest
fa46480 Respect DISPLAY environment variable in XWindows tests

📊 Changes

9 files changed (+54 additions, -22 deletions)

View changed files

📝 CMakeLists.txt (+2 -1)
📝 src/CMakeLists.txt (+4 -1)
📝 src/lib/barrier/KeyMap.h (+4 -0)
📝 src/test/CMakeLists.txt (+26 -12)
📝 src/test/integtests/CMakeLists.txt (+1 -3)
📝 src/test/integtests/platform/XWindowsScreenSaverTests.cpp (+7 -1)
📝 src/test/integtests/platform/XWindowsScreenTests.cpp (+7 -1)
📝 src/test/unittests/CMakeLists.txt (+1 -3)
📝 src/test/unittests/barrier/KeyMapTests.cpp (+2 -0)

📄 Description

These make the tests optional and allow the use of an external installation of the Google Test framework. This has been tested against GTest 1.10.0.

In case you're wondering, CMake includes a module for GTest but not GMock. There is an open issue about it.

Closes #586.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/846 **Author:** [@chewi](https://github.com/chewi) **Created:** 8/21/2020 **Status:** ✅ Merged **Merged:** 8/22/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `tests` --- ### 📝 Commits (3) - [`4a031b8`](https://github.com/debauchee/barrier/commit/4a031b8ce538af0c15857c37c1964bf144d5bc38) Add BARRIER_BUILD_TESTS CMake option to make tests optional - [`bd1db36`](https://github.com/debauchee/barrier/commit/bd1db368b333783697d686c82c42e48c4bec8b9e) Add BARRIER_USE_EXTERNAL_GTEST CMake option to use external GTest - [`fa46480`](https://github.com/debauchee/barrier/commit/fa46480c35d00a78b7d00f8a4ebc5b5d188b3030) Respect DISPLAY environment variable in XWindows tests ### 📊 Changes **9 files changed** (+54 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -1) 📝 `src/CMakeLists.txt` (+4 -1) 📝 `src/lib/barrier/KeyMap.h` (+4 -0) 📝 `src/test/CMakeLists.txt` (+26 -12) 📝 `src/test/integtests/CMakeLists.txt` (+1 -3) 📝 `src/test/integtests/platform/XWindowsScreenSaverTests.cpp` (+7 -1) 📝 `src/test/integtests/platform/XWindowsScreenTests.cpp` (+7 -1) 📝 `src/test/unittests/CMakeLists.txt` (+1 -3) 📝 `src/test/unittests/barrier/KeyMapTests.cpp` (+2 -0) </details> ### 📄 Description These make the tests optional and allow the use of an external installation of the Google Test framework. This has been tested against GTest 1.10.0. In case you're wondering, CMake includes a module for GTest but not GMock. There is [an open issue](https://gitlab.kitware.com/cmake/cmake/-/issues/17365) about it. Closes #586. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>