[PR #803] [MERGED] Regenerate server certificate when it is broken or has too small key size #1700

New issue

Closed

opened 2026-05-05 07:59:48 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:48 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/803
Author: @p12tic
Created: 7/19/2020
Status: ✅ Merged
Merged: 8/22/2020
Merged by: @p12tic

Base: master ← Head: crypto-cert-fixes

📝 Commits (6)

3d01866 net: Simplify error reporting
bd3a8be net: Always report the filename of the cert that fails to load
93ef157 gui: Don't store openssl output as state of the object
7210bfa gui: Extract certificate path generation to separate functions
345bb4b gui: Regenerate certificate if it's invalid or the key is too small
c815abf gui: Show certificate-related info in logs

📊 Changes

6 files changed (+116 additions, -43 deletions)

View changed files

📝 src/gui/CMakeLists.txt (+1 -1)
📝 src/gui/src/MainWindow.cpp (+4 -0)
📝 src/gui/src/SslCertificate.cpp (+92 -24)
📝 src/gui/src/SslCertificate.h (+7 -3)
📝 src/lib/net/SecureSocket.cpp (+10 -13)
📝 src/lib/net/SecureSocket.h (+2 -2)

📄 Description

Fixes #802.

Additionally logging is improved to show more information about what's happening.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/803 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 7/19/2020 **Status:** ✅ Merged **Merged:** 8/22/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `crypto-cert-fixes` --- ### 📝 Commits (6) - [`3d01866`](https://github.com/debauchee/barrier/commit/3d0186695fe1521a866d8bee65c9b07b0e4632cb) net: Simplify error reporting - [`bd3a8be`](https://github.com/debauchee/barrier/commit/bd3a8be9564d0af65642ca7d69efc4aa4274d1de) net: Always report the filename of the cert that fails to load - [`93ef157`](https://github.com/debauchee/barrier/commit/93ef15774bd92b29c220a7c1e36cd99fd1e364e3) gui: Don't store openssl output as state of the object - [`7210bfa`](https://github.com/debauchee/barrier/commit/7210bfa615cfcda7a794a44fb6e96b183bc248d5) gui: Extract certificate path generation to separate functions - [`345bb4b`](https://github.com/debauchee/barrier/commit/345bb4b62b8efd0b4274277a5c3bc48fe47b223e) gui: Regenerate certificate if it's invalid or the key is too small - [`c815abf`](https://github.com/debauchee/barrier/commit/c815abf0e8517f9aea6630f05ca098408946e080) gui: Show certificate-related info in logs ### 📊 Changes **6 files changed** (+116 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/CMakeLists.txt` (+1 -1) 📝 `src/gui/src/MainWindow.cpp` (+4 -0) 📝 `src/gui/src/SslCertificate.cpp` (+92 -24) 📝 `src/gui/src/SslCertificate.h` (+7 -3) 📝 `src/lib/net/SecureSocket.cpp` (+10 -13) 📝 `src/lib/net/SecureSocket.h` (+2 -2) </details> ### 📄 Description Fixes #802. Additionally logging is improved to show more information about what's happening. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>