mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[PR #750] [MERGED] ui: Settings: Explain what "double tap" means #1698
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#1698
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/debauchee/barrier/pull/750
Author: @nh2
Created: 6/14/2020
Status: ✅ Merged
Merged: 6/14/2020
Merged by: @p12tic
Base:
master← Head:double-tap-explanation📝 Commits (1)
03c1f06ui: Settings: Explain what "double tap" means📊 Changes
1 file changed (+57 additions, -43 deletions)
View changed files
📝
src/gui/src/ServerConfigDialogBase.ui(+57 -43)📄 Description
It took me half an hour, and a look at the code, to figure out what "double tap" means. I thought it meant "click", so I tried clicking around on the screen edge but it wouldn't do anything. I think it's a bad translation; probably a better English word for the motion would be "bump" or "edge bump".
In any case, a detailed explanation is better. So this PR adds a label
Screenshot of what it looks like with my change:
I think this way of explaining it is better than a tool-tip or Qt's
What's Thisfunctionality because most people don't know that those exist. An alternative would be to rename the setting from "tap" to "bump" (thus also changing the mnemonic key) and write on the settings screen something like "you can right-click each setting for a description of what it does" so thatWhat's thisis more discoverable, but I'd only do that after explaining the other settings as well, and that is more involved than this quick fix, which I think should be landed first.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.