[PR #747] [CLOSED] Issue 746: escape the comma in KeySequence #1694

New issue

Closed

opened 2026-05-05 07:59:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/747
Author: @VE3NEA
Created: 6/11/2020
Status: ❌ Closed

Base: master ← Head: issue-746

📝 Commits (1)

d0d01f2 Issue 746: escape the comma in KeySequence

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src/gui/src/KeySequence.cpp (+4 -0)

📄 Description

This PR fixes issue #746. QSettings seems to use the comma as a list separator. Because of this, KeySequence with a comma in it is saved fine to the settings file but cannot read back. The solution is to escape the comma.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/747 **Author:** [@VE3NEA](https://github.com/VE3NEA) **Created:** 6/11/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-746` --- ### 📝 Commits (1) - [`d0d01f2`](https://github.com/debauchee/barrier/commit/d0d01f26712f07e9798954e6be01871924d73f4e) Issue 746: escape the comma in KeySequence ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/src/KeySequence.cpp` (+4 -0) </details> ### 📄 Description This PR fixes [issue #746](https://github.com/debauchee/barrier/issues/746). `QSettings` seems to use the comma as a list separator. Because of this, `KeySequence` with a comma in it is saved fine to the settings file but cannot read back. The solution is to escape the comma. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>