[PR #732] [MERGED] Fix build on Windows #1692

New issue

Closed

opened 2026-05-05 07:59:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/732
Author: @GeorgH93
Created: 6/3/2020
Status: ✅ Merged
Merged: 6/4/2020
Merged by: @p12tic

Base: master ← Head: master

📝 Commits (2)

64a9320 Fix build on Windows
0ec5283 Keep errorlevel

📊 Changes

9 files changed (+12 additions, -4 deletions)

View changed files

📝 clean_build.bat (+4 -0)
📝 src/lib/arch/win32/ArchInternetWindows.cpp (+1 -0)
📝 src/lib/arch/win32/XArchWindows.cpp (+1 -0)
📝 src/lib/arch/win32/XArchWindows.h (+2 -2)
📝 src/lib/barrier/PlatformScreen.h (+1 -0)
📝 src/lib/base/IEventQueue.h (+1 -0)
📝 src/lib/platform/MSWindowsDesks.cpp (+1 -1)
📝 src/lib/platform/MSWindowsUtil.cpp (+1 -0)
📝 src/test/integtests/platform/MSWindowsKeyStateTests.cpp (+0 -1)

📄 Description

This fixes a couple of issues that prevented the project from being built on Windows.

I have also modified the clean_build.bat file to retain the ERRORLEVEL so that the azure pipeline should actually fail if the build fails (currently the build script always exits with status code 0 which I assume is the reason that the azure build succeeds even thou the build itself failed).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/732 **Author:** [@GeorgH93](https://github.com/GeorgH93) **Created:** 6/3/2020 **Status:** ✅ Merged **Merged:** 6/4/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`64a9320`](https://github.com/debauchee/barrier/commit/64a9320d611d98b954855bedf241f8a8dfb15fa7) Fix build on Windows - [`0ec5283`](https://github.com/debauchee/barrier/commit/0ec52835063905de1d01a9d2de5b4f2098d87c64) Keep errorlevel ### 📊 Changes **9 files changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `clean_build.bat` (+4 -0) 📝 `src/lib/arch/win32/ArchInternetWindows.cpp` (+1 -0) 📝 `src/lib/arch/win32/XArchWindows.cpp` (+1 -0) 📝 `src/lib/arch/win32/XArchWindows.h` (+2 -2) 📝 `src/lib/barrier/PlatformScreen.h` (+1 -0) 📝 `src/lib/base/IEventQueue.h` (+1 -0) 📝 `src/lib/platform/MSWindowsDesks.cpp` (+1 -1) 📝 `src/lib/platform/MSWindowsUtil.cpp` (+1 -0) 📝 `src/test/integtests/platform/MSWindowsKeyStateTests.cpp` (+0 -1) </details> ### 📄 Description This fixes a couple of issues that prevented the project from being built on Windows. I have also modified the clean_build.bat file to retain the ERRORLEVEL so that the azure pipeline should actually fail if the build fails (currently the build script always exits with status code 0 which I assume is the reason that the azure build succeeds even thou the build itself failed). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>