[PR #721] [MERGED] Proposal: Replace bundled gtest directory with Git submodule #1691

New issue

Closed

opened 2026-05-05 07:59:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/721
Author: @shymega
Created: 5/30/2020
Status: ✅ Merged
Merged: 6/8/2020
Merged by: @p12tic

Base: master ← Head: enhance/make-gtest-submodule

📝 Commits (3)

e9b82b4 Remove ext/gtest, ext/gmock to replace with Git submodule
938ad34 Add gtest/gmock framework, locked at 1.6.0
b16ad17 Fix CI infrastructure (.bat/.sh) to initialise Git submodules before build

📊 Changes

276 files changed (+14 additions, -256592 deletions)

View changed files

➕ .gitmodules (+6 -0)
📝 clean_build.bat (+2 -0)
📝 clean_build.sh (+4 -0)
➕ ext/gmock (+1 -0)
➖ ext/gmock/CHANGES (+0 -92)
➖ ext/gmock/CMakeLists.txt (+0 -151)
➖ ext/gmock/CONTRIBUTORS (+0 -40)
➖ ext/gmock/COPYING (+0 -28)
➖ ext/gmock/Makefile.am (+0 -209)
➖ ext/gmock/Makefile.in (+0 -1321)
➖ ext/gmock/README (+0 -354)
➖ ext/gmock/aclocal.m4 (+0 -9139)
➖ ext/gmock/build-aux/config.guess (+0 -1533)
➖ ext/gmock/build-aux/config.h.in (+0 -69)
➖ ext/gmock/build-aux/config.sub (+0 -1693)
➖ ext/gmock/build-aux/depcomp (+0 -630)
➖ ext/gmock/build-aux/install-sh (+0 -520)
➖ ext/gmock/build-aux/ltmain.sh (+0 -8413)
➖ ext/gmock/build-aux/missing (+0 -376)
➖ ext/gmock/configure (+0 -17795)

...and 80 more files

📄 Description

This PR replaces the bundled /ext/gtest directory with a Git submodule locked at the same release as before - 1.6.0 - but it should be considered to bump the release in the near future when and if possible.

Thoughts?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/721 **Author:** [@shymega](https://github.com/shymega) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 6/8/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `enhance/make-gtest-submodule` --- ### 📝 Commits (3) - [`e9b82b4`](https://github.com/debauchee/barrier/commit/e9b82b462cfed4f3ee812b1ad2857bc6380851e8) Remove ext/gtest, ext/gmock to replace with Git submodule - [`938ad34`](https://github.com/debauchee/barrier/commit/938ad34e2dd2b92374eadb4a4684aa0b71c22f3b) Add gtest/gmock framework, locked at 1.6.0 - [`b16ad17`](https://github.com/debauchee/barrier/commit/b16ad173400c27a1208b0925132bbf71014a83f8) Fix CI infrastructure (.bat/.sh) to initialise Git submodules before build ### 📊 Changes **276 files changed** (+14 additions, -256592 deletions) <details> <summary>View changed files</summary> ➕ `.gitmodules` (+6 -0) 📝 `clean_build.bat` (+2 -0) 📝 `clean_build.sh` (+4 -0) ➕ `ext/gmock` (+1 -0) ➖ `ext/gmock/CHANGES` (+0 -92) ➖ `ext/gmock/CMakeLists.txt` (+0 -151) ➖ `ext/gmock/CONTRIBUTORS` (+0 -40) ➖ `ext/gmock/COPYING` (+0 -28) ➖ `ext/gmock/Makefile.am` (+0 -209) ➖ `ext/gmock/Makefile.in` (+0 -1321) ➖ `ext/gmock/README` (+0 -354) ➖ `ext/gmock/aclocal.m4` (+0 -9139) ➖ `ext/gmock/build-aux/config.guess` (+0 -1533) ➖ `ext/gmock/build-aux/config.h.in` (+0 -69) ➖ `ext/gmock/build-aux/config.sub` (+0 -1693) ➖ `ext/gmock/build-aux/depcomp` (+0 -630) ➖ `ext/gmock/build-aux/install-sh` (+0 -520) ➖ `ext/gmock/build-aux/ltmain.sh` (+0 -8413) ➖ `ext/gmock/build-aux/missing` (+0 -376) ➖ `ext/gmock/configure` (+0 -17795) _...and 80 more files_ </details> ### 📄 Description This PR replaces the bundled `/ext/gtest` directory with a Git submodule locked at the same release as before - 1.6.0 - but it should be considered to bump the release in the near future when and if possible. Thoughts? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>