[PR #725] [MERGED] Make connection message a NOTE for consistency #1689

New issue

Closed

opened 2026-05-05 07:59:34 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:34 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/725
Author: @jmartens
Created: 6/1/2020
Status: ✅ Merged
Merged: 6/1/2020
Merged by: @shymega

Base: master ← Head: patch-2

📝 Commits (1)

583b2cb Make connection message a NOTE for consistency

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/barrier/ClientApp.cpp (+1 -1)

📄 Description

When disconnected a NOTE log entry is made in the log, when connected it just prints which seems inconsistent to me:

[2020-06-01T11:50:55] INFO: AES256-GCM-SHA384       TLSv1.2 Kx=RSA      Au=RSA  Enc=AESGCM(256) Mac=AEAD

	/home/jonathan/barrier/src/lib/net/SecureSocket.cpp,872
connected to server
[2020-06-01T11:52:43] INFO: entering screen

vs.

[2020-06-01T11:59:01] NOTE: disconnected from server
	/home/jonathan/barrier/src/lib/barrier/ClientApp.cpp,315

Since everything else logs with a timestamp I suggest changing this to NOTE as well for connection events being logged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/725 **Author:** [@jmartens](https://github.com/jmartens) **Created:** 6/1/2020 **Status:** ✅ Merged **Merged:** 6/1/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`583b2cb`](https://github.com/debauchee/barrier/commit/583b2cb5ae1fd513f88b996619d10c7e466363a2) Make connection message a NOTE for consistency ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/ClientApp.cpp` (+1 -1) </details> ### 📄 Description When disconnected a NOTE log entry is made in the log, when connected it just prints which seems inconsistent to me: ``` [2020-06-01T11:50:55] INFO: AES256-GCM-SHA384 TLSv1.2 Kx=RSA Au=RSA Enc=AESGCM(256) Mac=AEAD /home/jonathan/barrier/src/lib/net/SecureSocket.cpp,872 connected to server [2020-06-01T11:52:43] INFO: entering screen ``` vs. ``` [2020-06-01T11:59:01] NOTE: disconnected from server /home/jonathan/barrier/src/lib/barrier/ClientApp.cpp,315 ``` Since everything else logs with a timestamp I suggest changing this to NOTE as well for connection events being logged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>