[PR #718] [MERGED] Use noexcept instead of dynamic exception specifications #1688

New issue

Closed

opened 2026-05-05 07:59:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/718
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: use-noexcept

📝 Commits (2)

5eac13a Use noexcept instead of exception specifications
89c6623 lib/common: Remove no longer used stdexcept.h

📊 Changes

25 files changed (+79 additions, -118 deletions)

View changed files

📝 src/lib/arch/XArch.h (+3 -3)
📝 src/lib/arch/unix/XArchUnix.h (+1 -1)
📝 src/lib/arch/win32/XArchWindows.cpp (+2 -2)
📝 src/lib/barrier/PlatformScreen.h (+0 -1)
📝 src/lib/barrier/ProtocolUtil.cpp (+1 -1)
📝 src/lib/barrier/ProtocolUtil.h (+1 -1)
📝 src/lib/barrier/StreamChunker.cpp (+1 -1)
📝 src/lib/barrier/XBarrier.cpp (+10 -20)
📝 src/lib/barrier/XBarrier.h (+12 -12)
📝 src/lib/barrier/XScreen.cpp (+4 -4)
📝 src/lib/barrier/XScreen.h (+2 -2)
📝 src/lib/base/XBase.cpp (+3 -4)
📝 src/lib/base/XBase.h (+11 -11)
📝 src/lib/client/Client.cpp (+1 -1)
➖ src/lib/common/stdexcept.h (+0 -23)
📝 src/lib/io/XIO.cpp (+3 -3)
📝 src/lib/mt/XMT.cpp (+1 -1)
📝 src/lib/net/XSocket.cpp (+9 -12)
📝 src/lib/net/XSocket.h (+6 -6)
📝 src/lib/platform/MSWindowsWatchdog.h (+1 -1)

...and 5 more files

📄 Description

This PR changes code to use noexcept exclusively. Dynamic exception specifications have been removed completely out of C++20. Also macros such as _NOEXCEPT have been replaced with noexcept.

This PR depends on #717 to fix build issue due to missing #include.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/718 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-noexcept` --- ### 📝 Commits (2) - [`5eac13a`](https://github.com/debauchee/barrier/commit/5eac13a969163a77174acc5ddee21f1c0c32f3b4) Use noexcept instead of exception specifications - [`89c6623`](https://github.com/debauchee/barrier/commit/89c6623c0e40257f1da0b7637fc329aa5cf2388c) lib/common: Remove no longer used stdexcept.h ### 📊 Changes **25 files changed** (+79 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/arch/XArch.h` (+3 -3) 📝 `src/lib/arch/unix/XArchUnix.h` (+1 -1) 📝 `src/lib/arch/win32/XArchWindows.cpp` (+2 -2) 📝 `src/lib/barrier/PlatformScreen.h` (+0 -1) 📝 `src/lib/barrier/ProtocolUtil.cpp` (+1 -1) 📝 `src/lib/barrier/ProtocolUtil.h` (+1 -1) 📝 `src/lib/barrier/StreamChunker.cpp` (+1 -1) 📝 `src/lib/barrier/XBarrier.cpp` (+10 -20) 📝 `src/lib/barrier/XBarrier.h` (+12 -12) 📝 `src/lib/barrier/XScreen.cpp` (+4 -4) 📝 `src/lib/barrier/XScreen.h` (+2 -2) 📝 `src/lib/base/XBase.cpp` (+3 -4) 📝 `src/lib/base/XBase.h` (+11 -11) 📝 `src/lib/client/Client.cpp` (+1 -1) ➖ `src/lib/common/stdexcept.h` (+0 -23) 📝 `src/lib/io/XIO.cpp` (+3 -3) 📝 `src/lib/mt/XMT.cpp` (+1 -1) 📝 `src/lib/net/XSocket.cpp` (+9 -12) 📝 `src/lib/net/XSocket.h` (+6 -6) 📝 `src/lib/platform/MSWindowsWatchdog.h` (+1 -1) _...and 5 more files_ </details> ### 📄 Description This PR changes code to use `noexcept` exclusively. Dynamic exception specifications have been removed completely out of C++20. Also macros such as `_NOEXCEPT` have been replaced with `noexcept`. This PR depends on #717 to fix build issue due to missing #include. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>