[PR #714] [MERGED] lib/server: Use std::string directly instead of String typedef #1684

New issue

Closed

opened 2026-05-05 07:59:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/714
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: use-std-string-6

📝 Commits (1)

b4c1e4c lib/server: Use std::string directly instead of String typedef

📊 Changes

27 files changed (+334 additions, -415 deletions)

View changed files

📝 src/lib/server/BaseClientProxy.cpp (+2 -3)
📝 src/lib/server/BaseClientProxy.h (+3 -4)
📝 src/lib/server/ClientProxy.cpp (+1 -1)
📝 src/lib/server/ClientProxy.h (+1 -2)
📝 src/lib/server/ClientProxy1_0.cpp (+2 -1)
📝 src/lib/server/ClientProxy1_0.h (+1 -1)
📝 src/lib/server/ClientProxy1_1.cpp (+2 -1)
📝 src/lib/server/ClientProxy1_1.h (+1 -1)
📝 src/lib/server/ClientProxy1_2.cpp (+2 -1)
📝 src/lib/server/ClientProxy1_2.h (+1 -1)
📝 src/lib/server/ClientProxy1_3.cpp (+2 -1)
📝 src/lib/server/ClientProxy1_3.h (+1 -1)
📝 src/lib/server/ClientProxy1_4.cpp (+2 -1)
📝 src/lib/server/ClientProxy1_4.h (+2 -1)
📝 src/lib/server/ClientProxy1_5.cpp (+5 -4)
📝 src/lib/server/ClientProxy1_5.h (+2 -1)
📝 src/lib/server/ClientProxy1_6.cpp (+4 -3)
📝 src/lib/server/ClientProxy1_6.h (+2 -1)
📝 src/lib/server/ClientProxyUnknown.cpp (+1 -2)
📝 src/lib/server/Config.cpp (+145 -198)

...and 7 more files

📄 Description

Having a String typedef that points to std::string does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/714 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-std-string-6` --- ### 📝 Commits (1) - [`b4c1e4c`](https://github.com/debauchee/barrier/commit/b4c1e4c2390de6299f287f11282fa523321272da) lib/server: Use std::string directly instead of String typedef ### 📊 Changes **27 files changed** (+334 additions, -415 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/server/BaseClientProxy.cpp` (+2 -3) 📝 `src/lib/server/BaseClientProxy.h` (+3 -4) 📝 `src/lib/server/ClientProxy.cpp` (+1 -1) 📝 `src/lib/server/ClientProxy.h` (+1 -2) 📝 `src/lib/server/ClientProxy1_0.cpp` (+2 -1) 📝 `src/lib/server/ClientProxy1_0.h` (+1 -1) 📝 `src/lib/server/ClientProxy1_1.cpp` (+2 -1) 📝 `src/lib/server/ClientProxy1_1.h` (+1 -1) 📝 `src/lib/server/ClientProxy1_2.cpp` (+2 -1) 📝 `src/lib/server/ClientProxy1_2.h` (+1 -1) 📝 `src/lib/server/ClientProxy1_3.cpp` (+2 -1) 📝 `src/lib/server/ClientProxy1_3.h` (+1 -1) 📝 `src/lib/server/ClientProxy1_4.cpp` (+2 -1) 📝 `src/lib/server/ClientProxy1_4.h` (+2 -1) 📝 `src/lib/server/ClientProxy1_5.cpp` (+5 -4) 📝 `src/lib/server/ClientProxy1_5.h` (+2 -1) 📝 `src/lib/server/ClientProxy1_6.cpp` (+4 -3) 📝 `src/lib/server/ClientProxy1_6.h` (+2 -1) 📝 `src/lib/server/ClientProxyUnknown.cpp` (+1 -2) 📝 `src/lib/server/Config.cpp` (+145 -198) _...and 7 more files_ </details> ### 📄 Description Having a `String` typedef that points to `std::string` does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>