[PR #709] [MERGED] lib/base: Use std::string directly instead of String typedef #1681

New issue

Closed

opened 2026-05-05 07:59:20 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:20 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/709
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: use-std-string-1

📝 Commits (1)

61771d9 lib/base: Use std::string directly instead of String typedef

📊 Changes

19 files changed (+156 additions, -176 deletions)

View changed files

📝 src/lib/barrier/ProtocolUtil.h (+3 -3)
📝 src/lib/barrier/XBarrier.h (+10 -12)
📝 src/lib/barrier/XScreen.cpp (+3 -6)
📝 src/lib/barrier/XScreen.h (+1 -1)
📝 src/lib/base/EventQueue.cpp (+1 -2)
📝 src/lib/base/EventQueue.h (+2 -3)
📝 src/lib/base/IEventQueue.h (+1 -2)
📝 src/lib/base/Log.cpp (+0 -1)
📝 src/lib/base/String.cpp (+29 -33)
📝 src/lib/base/String.h (+20 -20)
📝 src/lib/base/Unicode.cpp (+40 -41)
📝 src/lib/base/Unicode.h (+20 -22)
📝 src/lib/base/XBase.cpp (+3 -3)
📝 src/lib/base/XBase.h (+13 -14)
📝 src/lib/base/log_outputters.cpp (+3 -2)
📝 src/lib/base/log_outputters.h (+2 -2)
📝 src/lib/io/XIO.cpp (+3 -6)
📝 src/lib/mt/XMT.cpp (+1 -2)
📝 src/test/mock/barrier/MockEventQueue.h (+1 -1)

📄 Description

Having a String typedef that points to std::string does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/709 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-std-string-1` --- ### 📝 Commits (1) - [`61771d9`](https://github.com/debauchee/barrier/commit/61771d903967d1f4c9439029e8123b3a8d1bde40) lib/base: Use std::string directly instead of String typedef ### 📊 Changes **19 files changed** (+156 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/ProtocolUtil.h` (+3 -3) 📝 `src/lib/barrier/XBarrier.h` (+10 -12) 📝 `src/lib/barrier/XScreen.cpp` (+3 -6) 📝 `src/lib/barrier/XScreen.h` (+1 -1) 📝 `src/lib/base/EventQueue.cpp` (+1 -2) 📝 `src/lib/base/EventQueue.h` (+2 -3) 📝 `src/lib/base/IEventQueue.h` (+1 -2) 📝 `src/lib/base/Log.cpp` (+0 -1) 📝 `src/lib/base/String.cpp` (+29 -33) 📝 `src/lib/base/String.h` (+20 -20) 📝 `src/lib/base/Unicode.cpp` (+40 -41) 📝 `src/lib/base/Unicode.h` (+20 -22) 📝 `src/lib/base/XBase.cpp` (+3 -3) 📝 `src/lib/base/XBase.h` (+13 -14) 📝 `src/lib/base/log_outputters.cpp` (+3 -2) 📝 `src/lib/base/log_outputters.h` (+2 -2) 📝 `src/lib/io/XIO.cpp` (+3 -6) 📝 `src/lib/mt/XMT.cpp` (+1 -2) 📝 `src/test/mock/barrier/MockEventQueue.h` (+1 -1) </details> ### 📄 Description Having a `String` typedef that points to `std::string` does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>