[PR #708] [MERGED] gui: Use enum class to scope enum values #1679

New issue

Closed

opened 2026-05-05 07:59:19 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:19 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/708
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: enum-class

📝 Commits (1)

94a280a gui: Use enum class to scope enum values

📊 Changes

7 files changed (+171 additions, -95 deletions)

View changed files

📝 src/gui/src/BaseConfig.h (+54 -18)
📝 src/gui/src/Screen.cpp (+43 -22)
📝 src/gui/src/Screen.h (+14 -9)
📝 src/gui/src/ScreenSettingsDialog.cpp (+35 -30)
📝 src/gui/src/ServerConfig.cpp (+11 -6)
📝 src/gui/src/ServerConfig.h (+2 -2)
📝 src/gui/src/ServerConfigDialog.cpp (+12 -8)

📄 Description

We were using unscoped enums which leaked the identifiers all over the place. This is a prerequisite for enabling tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/708 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `enum-class` --- ### 📝 Commits (1) - [`94a280a`](https://github.com/debauchee/barrier/commit/94a280a82b64e55a338bd66fa161cc3d753014a3) gui: Use enum class to scope enum values ### 📊 Changes **7 files changed** (+171 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/src/BaseConfig.h` (+54 -18) 📝 `src/gui/src/Screen.cpp` (+43 -22) 📝 `src/gui/src/Screen.h` (+14 -9) 📝 `src/gui/src/ScreenSettingsDialog.cpp` (+35 -30) 📝 `src/gui/src/ServerConfig.cpp` (+11 -6) 📝 `src/gui/src/ServerConfig.h` (+2 -2) 📝 `src/gui/src/ServerConfigDialog.cpp` (+12 -8) </details> ### 📄 Description We were using unscoped enums which leaked the identifiers all over the place. This is a prerequisite for enabling tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>