[PR #648] [MERGED] Use macdeployqt #1667

New issue

Closed

opened 2026-05-05 07:59:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/648
Author: @simons-public
Created: 5/2/2020
Status: ✅ Merged
Merged: 5/6/2020
Merged by: @shymega

Base: master ← Head: use-macdeployqt

📝 Commits (6)

e37277f Add script that uses macdeployqt instead of reref_dylibs.sh shell script to create the .app bundle
8cd59eb Use build_dist.sh in CMake instead of build_installer.sh
fb3eaa3 Add warnings for users manually running build_installer.sh and reref_dylibs.sh manually
e0051d1 Homebrew (Ruby) throws an error when it gets SIGPIPE from the --max-count on grep.
0deaaad added barrierc and barriers to macdeployqt targets
b5c7eb4 Change MacOS Build Steps

📊 Changes

5 files changed (+97 additions, -10 deletions)

View changed files

📝 CMakeLists.txt (+4 -6)
📝 azure-pipelines.yml (+9 -4)
➕ dist/macos/bundle/build_dist.sh.in (+73 -0)
📝 dist/macos/bundle/build_installer.sh.in (+5 -0)
📝 dist/macos/bundle/reref_dylibs.sh (+6 -0)

📄 Description

Making a release was failing with both Homebrew and MacPorts on Mojave. The compiled binary would run successfully, but the resulting .app bundle from running build_installer.sh (which runs reref_dylibs.sh and builds the .app bundle) was giving SEGFAULT 11 when executed.

This pull request replaces build_installer.sh with build_dist.sh that runs the Qt toolkit's macdeployqt which is included with the Qt on both MacPorts and Homebrew. It builds the distributable bundle and creates the dmg if it is a Release build.

The previous scripts have been left in place with deprecation warnings in case they are still needed by older versions of MacOS.

It also removes the if condition in CMake that prevents building a bundle on Debug releases.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/648 **Author:** [@simons-public](https://github.com/simons-public) **Created:** 5/2/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-macdeployqt` --- ### 📝 Commits (6) - [`e37277f`](https://github.com/debauchee/barrier/commit/e37277fe8f5ecd1ec0c625d19923f3e49c0cd6e8) Add script that uses macdeployqt instead of `reref_dylibs.sh` shell script to create the `.app` bundle - [`8cd59eb`](https://github.com/debauchee/barrier/commit/8cd59ebee7f04706a42c2c7dfa684d2ecdb7ac98) Use `build_dist.sh` in CMake instead of `build_installer.sh` - [`fb3eaa3`](https://github.com/debauchee/barrier/commit/fb3eaa3e3cde0f448b2f7d2aaf5445accef2f56d) Add warnings for users manually running `build_installer.sh` and `reref_dylibs.sh` manually - [`e0051d1`](https://github.com/debauchee/barrier/commit/e0051d17d89f25f88c65e1b7fa6e934e44166682) Homebrew (Ruby) throws an error when it gets `SIGPIPE` from the `--max-count` on `grep`. - [`0deaaad`](https://github.com/debauchee/barrier/commit/0deaaad2c978ef4ee5e20bace8112dc7bd811d67) added barrierc and barriers to macdeployqt targets - [`b5c7eb4`](https://github.com/debauchee/barrier/commit/b5c7eb45efd0aa363c06a60e31a834c231b3aeb6) Change MacOS Build Steps ### 📊 Changes **5 files changed** (+97 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+4 -6) 📝 `azure-pipelines.yml` (+9 -4) ➕ `dist/macos/bundle/build_dist.sh.in` (+73 -0) 📝 `dist/macos/bundle/build_installer.sh.in` (+5 -0) 📝 `dist/macos/bundle/reref_dylibs.sh` (+6 -0) </details> ### 📄 Description Making a release was failing with both Homebrew and MacPorts on Mojave. The compiled binary would run successfully, but the resulting `.app` bundle from running `build_installer.sh` (which runs `reref_dylibs.sh` and builds the `.app` bundle) was giving SEGFAULT 11 when executed. This pull request replaces `build_installer.sh` with `build_dist.sh` that runs the Qt toolkit's `macdeployqt` which is included with the Qt on both MacPorts and Homebrew. It builds the distributable bundle and creates the `dmg` if it is a Release build. The previous scripts have been left in place with deprecation warnings in case they are still needed by older versions of MacOS. It also removes the `if` condition in CMake that prevents building a bundle on Debug releases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>