mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[PR #642] [CLOSED] Todo libqcocoa #1665
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#1665
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/debauchee/barrier/pull/642
Author: @simons-public
Created: 4/29/2020
Status: ❌ Closed
Base:
master← Head:TODO-libqcocoa📝 Commits (2)
4582cdcchanged method of finding libqcocoa.dylibc4a831cbuild_installer.sh: better to check if $B_COCOA is not a file than if it is an empty string📊 Changes
1 file changed (+5 additions, -7 deletions)
View changed files
📝
dist/macos/bundle/build_installer.sh.in(+5 -7)📄 Description
Saw the output
find: /usr/local/Cellar/qt: No such file or directory(using macports) when runningbuild_installer.shand noticed the TODO. This method checks for the dylib that is loaded when running thebarrierbinary instead of relying on thefindutility. It should function if there is more than one Qt version installed.Also changed so that it bails if the
$B_COCOAis not a file path instead of bailing only if it is an empty string.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.