[PR #592] [MERGED] Only require Qt5 when building the GUI #1662

Closed
opened 2026-05-05 07:58:53 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/592
Author: @chewi
Created: 3/17/2020
Status: Merged
Merged: 3/26/2020
Merged by: @shymega

Base: masterHead: qt-gui-only


📝 Commits (1)

  • af0ce63 Only require Qt5 when building the GUI

📊 Changes

2 files changed (+1 additions, -7 deletions)

View changed files

📝 CMakeLists.txt (+0 -6)
📝 src/gui/CMakeLists.txt (+1 -1)

📄 Description

Commit 6c888437 made Qt5 mandatory for all builds when it is only required for the GUI. There's already a find_package call in src/gui, it just needed the REQUIRED flag to be added.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/592 **Author:** [@chewi](https://github.com/chewi) **Created:** 3/17/2020 **Status:** ✅ Merged **Merged:** 3/26/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `qt-gui-only` --- ### 📝 Commits (1) - [`af0ce63`](https://github.com/debauchee/barrier/commit/af0ce63733e040d6220aaa2157190015d4a9b0fd) Only require Qt5 when building the GUI ### 📊 Changes **2 files changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+0 -6) 📝 `src/gui/CMakeLists.txt` (+1 -1) </details> ### 📄 Description Commit 6c888437 made Qt5 mandatory for all builds when it is only required for the GUI. There's already a `find_package` call in src/gui, it just needed the `REQUIRED` flag to be added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:58:53 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1662
No description provided.