[PR #504] [MERGED] Let tray image blend into macOS menu bar #1645

New issue

Closed

opened 2026-05-05 07:58:29 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:58:29 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/504
Author: @tiwoc
Created: 11/21/2019
Status: ✅ Merged
Merged: 11/21/2019
Merged by: @AdrianKoshka

Base: master ← Head: macos-tray-image

📝 Commits (1)

8ef0668 Let tray image blend into macOS menu bar

📊 Changes

8 files changed (+381 additions, -2 deletions)

View changed files

📝 src/gui/res/Barrier.qrc (+3 -0)
➕ src/gui/res/icons/32x32/barrier-connected-mask.png (+0 -0)
➕ src/gui/res/icons/32x32/barrier-connected-mask.svg (+114 -0)
➕ src/gui/res/icons/32x32/barrier-disconnected-mask.png (+0 -0)
➕ src/gui/res/icons/32x32/barrier-disconnected-mask.svg (+102 -0)
➕ src/gui/res/icons/32x32/barrier-transfering-mask.png (+0 -0)
➕ src/gui/res/icons/32x32/barrier-transfering-mask.svg (+148 -0)
📝 src/gui/src/MainWindow.cpp (+14 -2)

📄 Description

The expected style for macOS menu bar images is a template image than can adapt to the user's appearance settings. Also, high-res screens ("Retina" in Apple speak) need higher resolution images.

Without this PR (Light Mode):
before-light
Without this PR (Dark Mode):
before-dark

With this PR (Light Mode):
after-light
With this PR (Dark Mode):
after-dark

Based on /res/barrier.svg, I created black and transparent SVGs for the three icon states. I had to remove some details to make the image scale down to icon size without becoming too crowded, and I drew a new checkmark and the transfer arrow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/504 **Author:** [@tiwoc](https://github.com/tiwoc) **Created:** 11/21/2019 **Status:** ✅ Merged **Merged:** 11/21/2019 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `macos-tray-image` --- ### 📝 Commits (1) - [`8ef0668`](https://github.com/debauchee/barrier/commit/8ef0668b099ce1c4bdf1fb5f8a34d96ec2256033) Let tray image blend into macOS menu bar ### 📊 Changes **8 files changed** (+381 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/res/Barrier.qrc` (+3 -0) ➕ `src/gui/res/icons/32x32/barrier-connected-mask.png` (+0 -0) ➕ `src/gui/res/icons/32x32/barrier-connected-mask.svg` (+114 -0) ➕ `src/gui/res/icons/32x32/barrier-disconnected-mask.png` (+0 -0) ➕ `src/gui/res/icons/32x32/barrier-disconnected-mask.svg` (+102 -0) ➕ `src/gui/res/icons/32x32/barrier-transfering-mask.png` (+0 -0) ➕ `src/gui/res/icons/32x32/barrier-transfering-mask.svg` (+148 -0) 📝 `src/gui/src/MainWindow.cpp` (+14 -2) </details> ### 📄 Description The [expected style](https://developer.apple.com/design/human-interface-guidelines/macos/extensions/menu-bar-extras/) for macOS menu bar images is a template image than can adapt to the user's appearance settings. Also, high-res screens ("Retina" in Apple speak) need higher resolution images. Without this PR (Light Mode): <img width="339" alt="before-light" src="https://user-images.githubusercontent.com/1260821/69326721-91b7a180-0c4c-11ea-8abc-c6eeea1ea248.png"> Without this PR (Dark Mode): <img width="339" alt="before-dark" src="https://user-images.githubusercontent.com/1260821/69326720-91b7a180-0c4c-11ea-94bf-534b89c0428a.png"> ---- With this PR (Light Mode): <img width="339" alt="after-light" src="https://user-images.githubusercontent.com/1260821/69326719-911f0b00-0c4c-11ea-85b9-632eac4b017c.png"> With this PR (Dark Mode): <img width="339" alt="after-dark" src="https://user-images.githubusercontent.com/1260821/69326716-911f0b00-0c4c-11ea-8a59-5dc6d934cb13.png"> Based on /res/barrier.svg, I created black and transparent SVGs for the three icon states. I had to remove some details to make the image scale down to icon size without becoming too crowded, and I drew a new checkmark and the transfer arrow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>