[PR #391] [MERGED] Re-implement patch for horizontal scrolling and extra mouse buttons #1619

New issue

Closed

opened 2026-05-05 07:57:52 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:57:52 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/391
Author: @EbonJaeger
Created: 8/6/2019
Status: ✅ Merged
Merged: 8/22/2019
Merged by: @AdrianKoshka

Base: master ← Head: scroll-and-mouse-buttons-squashed

📝 Commits (3)

9f15b1b Reimplement patch for horizontal scrolling and extra mouse buttons
00c18b4 Used the wrong key button by accident
0cd2e6b Use Windows helper function to check for Windows version

📊 Changes

9 files changed (+111 additions, -81 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 src/lib/barrier/mouse_types.h (+4 -1)
📝 src/lib/platform/MSWindowsDesks.cpp (+10 -3)
📝 src/lib/platform/MSWindowsHook.cpp (+11 -0)
📝 src/lib/platform/MSWindowsScreen.cpp (+5 -6)
📝 src/lib/platform/MSWindowsScreen.h (+1 -1)
📝 src/lib/platform/OSXScreen.mm (+1 -0)
📝 src/lib/platform/XWindowsScreen.cpp (+72 -66)
📝 src/lib/platform/XWindowsScreen.h (+6 -4)

📄 Description

Re-implementation of #242 for the newer CI's and an up to date codebase. Both horizontal scrolling and extra mouse buttons (buttons 4 and 5, sometimes also referred to as forward and back) have been tested between Windows 10 and Linux (Solus OS). I don't have any macOS devices, so if someone wants to build this to test that platform, that might be a good idea.

Aside from some formatting and a couple of additional comments, there are no significant changes from the original work done in the previous PR.

Fixes #51

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/391 **Author:** [@EbonJaeger](https://github.com/EbonJaeger) **Created:** 8/6/2019 **Status:** ✅ Merged **Merged:** 8/22/2019 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `scroll-and-mouse-buttons-squashed` --- ### 📝 Commits (3) - [`9f15b1b`](https://github.com/debauchee/barrier/commit/9f15b1bcf2953acf609f7580463bf13cdb23d008) Reimplement patch for horizontal scrolling and extra mouse buttons - [`00c18b4`](https://github.com/debauchee/barrier/commit/00c18b4c92c39fa35f07797286179cc11e18370e) Used the wrong key button by accident - [`0cd2e6b`](https://github.com/debauchee/barrier/commit/0cd2e6bb6cf0b34fd069431e36bf79a41c05e968) Use Windows helper function to check for Windows version ### 📊 Changes **9 files changed** (+111 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `src/lib/barrier/mouse_types.h` (+4 -1) 📝 `src/lib/platform/MSWindowsDesks.cpp` (+10 -3) 📝 `src/lib/platform/MSWindowsHook.cpp` (+11 -0) 📝 `src/lib/platform/MSWindowsScreen.cpp` (+5 -6) 📝 `src/lib/platform/MSWindowsScreen.h` (+1 -1) 📝 `src/lib/platform/OSXScreen.mm` (+1 -0) 📝 `src/lib/platform/XWindowsScreen.cpp` (+72 -66) 📝 `src/lib/platform/XWindowsScreen.h` (+6 -4) </details> ### 📄 Description Re-implementation of #242 for the newer CI's and an up to date codebase. Both horizontal scrolling and extra mouse buttons (buttons 4 and 5, sometimes also referred to as forward and back) have been tested between Windows 10 and Linux (Solus OS). I don't have any macOS devices, so if someone wants to build this to test that platform, that might be a good idea. Aside from some formatting and a couple of additional comments, there are no significant changes from the original work done in the previous PR. Fixes #51 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>