[PR #287] [MERGED] Windows installer fix #1593

New issue

Closed

opened 2026-05-05 07:57:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:57:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/287
Author: @noisyshape
Created: 4/12/2019
Status: ✅ Merged
Merged: 4/21/2019
Merged by: @AdrianKoshka

Base: master ← Head: windows-installer-fix

📝 Commits (5)

4afa31a Correct path and instructions
6a70ef9 Create version number for wix
cdf3737 Remove hardcoded paths
35e6693 Fix XML
18ac0fe Replace Wix with Inno Setup

📊 Changes

4 files changed (+12 additions, -13 deletions)

View changed files

📝 CMakeLists.txt (+1 -0)
📝 build_installer.bat (+8 -9)
📝 dist/wix/Include.wxi.in (+3 -3)
📝 dist/wix/Product.wxs (+0 -1)

📄 Description

Fix for #286. build_installer.bat now works. Steps for building the installer:

Install Wix Toolset 3.11
Create a Release build with clean_build.bat
Run build_installer.bat

You should then have an MSI installer in build/installer-wix/bin/. It does not detect or uninstall the 2.1.0 release. It needs to be tested for other issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/287 **Author:** [@noisyshape](https://github.com/noisyshape) **Created:** 4/12/2019 **Status:** ✅ Merged **Merged:** 4/21/2019 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `windows-installer-fix` --- ### 📝 Commits (5) - [`4afa31a`](https://github.com/debauchee/barrier/commit/4afa31ac54c81b33253579e16842fb03ac5c227e) Correct path and instructions - [`6a70ef9`](https://github.com/debauchee/barrier/commit/6a70ef9efbdd0dc1ec201bcbdc206e1d0c9f70ef) Create version number for wix - [`cdf3737`](https://github.com/debauchee/barrier/commit/cdf37376f52c0a7f8e097d8ec948a6a7843d20fb) Remove hardcoded paths - [`35e6693`](https://github.com/debauchee/barrier/commit/35e6693d6d22a226c106ac6461c351aa35569769) Fix XML - [`18ac0fe`](https://github.com/debauchee/barrier/commit/18ac0fe4b5ff17d3009067b4389a6fa284b7323a) Replace Wix with Inno Setup ### 📊 Changes **4 files changed** (+12 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -0) 📝 `build_installer.bat` (+8 -9) 📝 `dist/wix/Include.wxi.in` (+3 -3) 📝 `dist/wix/Product.wxs` (+0 -1) </details> ### 📄 Description Fix for #286. build_installer.bat now works. Steps for building the installer: 1. Install Wix Toolset 3.11 2. Create a Release build with clean_build.bat 3. Run build_installer.bat You should then have an MSI installer in build/installer-wix/bin/. It does not detect or uninstall the 2.1.0 release. It needs to be tested for other issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>