[PR #283] [MERGED] Update Windows build script for VS2019 #1592

New issue

Closed

opened 2026-05-05 07:57:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:57:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/283
Author: @noisyshape
Created: 4/10/2019
Status: ✅ Merged
Merged: 4/12/2019
Merged by: @AdrianKoshka

Base: master ← Head: vs2019-build

📝 Commits (3)

47aac50 Update Windows build script for VS2019
3e6095f Add support for multiple VS versions
0af43a2 Normalize cmake generator strings

📊 Changes

1 file changed (+14 additions, -1 deletions)

View changed files

📝 clean_build.bat (+14 -1)

📄 Description

I updated clean_build.bat with the cmake generator argument for Visual Studio 2019. VS2019 is what Microsoft is pushing now and what people will download if you tell them to download Visual Studio.

I also took the opportunity to move the generator string into its own variable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/283 **Author:** [@noisyshape](https://github.com/noisyshape) **Created:** 4/10/2019 **Status:** ✅ Merged **Merged:** 4/12/2019 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `vs2019-build` --- ### 📝 Commits (3) - [`47aac50`](https://github.com/debauchee/barrier/commit/47aac5081f7233bd9dcb3b4d5c066155a9d318c2) Update Windows build script for VS2019 - [`3e6095f`](https://github.com/debauchee/barrier/commit/3e6095fc34687ace2f21d1f7088b5d3e328da2ba) Add support for multiple VS versions - [`0af43a2`](https://github.com/debauchee/barrier/commit/0af43a24884791167ef2009e73dfd760a7a9722a) Normalize cmake generator strings ### 📊 Changes **1 file changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `clean_build.bat` (+14 -1) </details> ### 📄 Description I updated clean_build.bat with the cmake generator argument for Visual Studio 2019. VS2019 is what Microsoft is pushing now and what people will download if you tell them to download Visual Studio. I also took the opportunity to move the generator string into its own variable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>