[PR #205] [MERGED] add debug notes to help identify where trusted fingerprints file is #1576

New issue

Closed

opened 2026-05-05 07:56:43 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:43 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/205
Author: @dayne
Created: 12/20/2018
Status: ✅ Merged
Merged: 12/26/2018
Merged by: @AdrianKoshka

Base: master ← Head: fingerprint_debug

📝 Commits (3)

48438dc add debug notes to help identify where trusted fingerprints file is
c5add29 fix spelling of matches
69dc2c3 fixing style to be consistent per @p12tic

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 src/lib/net/SecureSocket.cpp (+12 -0)

📄 Description

Debugging on a client where the TrustedServers fingerprint is being loaded from can be confusing. It appears different systems store it in different locations, and this location can change a bit over time.

Currently if you don't correctly identify the right file to populate, or populate it with the wrong fingerprint you aren't given any hints. Just a message failed to verify server certificate fingerprint.

This PR adds a few additional debug notes to help folks identify the specific file being loaded for use in checking server fingerprint trust and should improve self-debugging by users.

With the additional messages a user can:

identify what file barrierc is trying to open to look for trustedServers
see if that file was successfully opened
get notification if there was a mismatch between contents of file and the server fingerprint

The result looks like so:

[2018-12-19T20:35:49] NOTE: connecting to 'gilbert.lan': 192.168.86.148:24800
[2018-12-19T20:35:49] NOTE: server fingerprint: 53:66:BF:37:CF:ED:60:43:3C:84:86:57:2C:E3:2E:20:68:A0:0C:35
[2018-12-19T20:35:49] NOTE: trustedServersFilename: /home/pi/.local/share/barrier/SSL/Fingerprints/TrustedServers.txt
[2018-12-19T20:35:49] NOTE: Opened trustedServersFilename: /home/pi/.local/share/barrier/SSL/Fingerprints/TrustedServers.txt
[2018-12-19T20:35:49] NOTE: Fingerprint matches trusted fingerprint
[2018-12-19T20:35:49] NOTE: connected to server

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/205 **Author:** [@dayne](https://github.com/dayne) **Created:** 12/20/2018 **Status:** ✅ Merged **Merged:** 12/26/2018 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `fingerprint_debug` --- ### 📝 Commits (3) - [`48438dc`](https://github.com/debauchee/barrier/commit/48438dc34c3355f8a66000dd124c3bd3f51cac8c) add debug notes to help identify where trusted fingerprints file is - [`c5add29`](https://github.com/debauchee/barrier/commit/c5add29cb0f125310af974c0f51faca6d8cbffe2) fix spelling of matches - [`69dc2c3`](https://github.com/debauchee/barrier/commit/69dc2c30dc3bf058130f968fba3b68aa46ef1e4f) fixing style to be consistent per @p12tic ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/net/SecureSocket.cpp` (+12 -0) </details> ### 📄 Description Debugging on a client where the TrustedServers fingerprint is being loaded from can be confusing. It appears different systems store it in different locations, and this location can change a bit over time. Currently if you don't correctly identify the right file to populate, or populate it with the wrong fingerprint you aren't given any hints. Just a message `failed to verify server certificate fingerprint`. This PR adds a few additional debug notes to help folks identify the specific file being loaded for use in checking server fingerprint trust and should improve self-debugging by users. With the additional messages a user can: * identify what file `barrierc` is trying to open to look for trustedServers * see if that file was successfully opened * get notification if there was a mismatch between contents of file and the server fingerprint The result looks like so: ``` [2018-12-19T20:35:49] NOTE: connecting to 'gilbert.lan': 192.168.86.148:24800 [2018-12-19T20:35:49] NOTE: server fingerprint: 53:66:BF:37:CF:ED:60:43:3C:84:86:57:2C:E3:2E:20:68:A0:0C:35 [2018-12-19T20:35:49] NOTE: trustedServersFilename: /home/pi/.local/share/barrier/SSL/Fingerprints/TrustedServers.txt [2018-12-19T20:35:49] NOTE: Opened trustedServersFilename: /home/pi/.local/share/barrier/SSL/Fingerprints/TrustedServers.txt [2018-12-19T20:35:49] NOTE: Fingerprint matches trusted fingerprint [2018-12-19T20:35:49] NOTE: connected to server ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>