[PR #172] [MERGED] x11: Wrap platform functions in an interface that can be mocked later #1572

New issue

Closed

opened 2026-05-05 07:56:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/172
Author: @mokibit
Created: 11/7/2018
Status: ✅ Merged
Merged: 11/13/2018
Merged by: @AdrianKoshka

Base: master ← Head: tests

📝 Commits (5)

3a87341 x11: Wrap platform functions in an interface that can be mocked later
88a634b x11: Wrap platform functions in XWindowsScreenSaver class
7539852 x11: Wrap platform functions in XWindowsClipboard class
a6265c8 x11: Wrap platform functions in XWindowsKeyState class
2675038 x11: Wrap platform functions in XWindowsEventQueueBuffer class

📊 Changes

15 files changed (+1371 additions, -282 deletions)

View changed files

📝 src/lib/barrier/ClientApp.cpp (+1 -0)
📝 src/lib/barrier/ServerApp.cpp (+1 -0)
➕ src/lib/platform/IXWindowsImpl.h (+234 -0)
📝 src/lib/platform/XWindowsClipboard.cpp (+42 -36)
📝 src/lib/platform/XWindowsClipboard.h (+4 -1)
📝 src/lib/platform/XWindowsEventQueueBuffer.cpp (+7 -6)
📝 src/lib/platform/XWindowsEventQueueBuffer.h (+4 -1)
➕ src/lib/platform/XWindowsImpl.cpp (+646 -0)
➕ src/lib/platform/XWindowsImpl.h (+196 -0)
📝 src/lib/platform/XWindowsKeyState.cpp (+47 -37)
📝 src/lib/platform/XWindowsKeyState.h (+7 -3)
📝 src/lib/platform/XWindowsScreen.cpp (+124 -152)
📝 src/lib/platform/XWindowsScreen.h (+4 -1)
📝 src/lib/platform/XWindowsScreenSaver.cpp (+49 -44)
📝 src/lib/platform/XWindowsScreenSaver.h (+5 -1)

📄 Description

First PR out of many for #76. Discussed and coordinated with @p12tic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/172 **Author:** [@mokibit](https://github.com/mokibit) **Created:** 11/7/2018 **Status:** ✅ Merged **Merged:** 11/13/2018 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `tests` --- ### 📝 Commits (5) - [`3a87341`](https://github.com/debauchee/barrier/commit/3a87341992cdf6aec7c29a46bc22eac4606e1107) x11: Wrap platform functions in an interface that can be mocked later - [`88a634b`](https://github.com/debauchee/barrier/commit/88a634b1de13201b3057428dc06c5fee239562b2) x11: Wrap platform functions in XWindowsScreenSaver class - [`7539852`](https://github.com/debauchee/barrier/commit/75398523772f19cac118df1a1282093471fc03d4) x11: Wrap platform functions in XWindowsClipboard class - [`a6265c8`](https://github.com/debauchee/barrier/commit/a6265c8d3ec5108974b62c34c785a228f310f651) x11: Wrap platform functions in XWindowsKeyState class - [`2675038`](https://github.com/debauchee/barrier/commit/26750384fd9ed6bb7cb79a0228efbbaa04dc6131) x11: Wrap platform functions in XWindowsEventQueueBuffer class ### 📊 Changes **15 files changed** (+1371 additions, -282 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/ClientApp.cpp` (+1 -0) 📝 `src/lib/barrier/ServerApp.cpp` (+1 -0) ➕ `src/lib/platform/IXWindowsImpl.h` (+234 -0) 📝 `src/lib/platform/XWindowsClipboard.cpp` (+42 -36) 📝 `src/lib/platform/XWindowsClipboard.h` (+4 -1) 📝 `src/lib/platform/XWindowsEventQueueBuffer.cpp` (+7 -6) 📝 `src/lib/platform/XWindowsEventQueueBuffer.h` (+4 -1) ➕ `src/lib/platform/XWindowsImpl.cpp` (+646 -0) ➕ `src/lib/platform/XWindowsImpl.h` (+196 -0) 📝 `src/lib/platform/XWindowsKeyState.cpp` (+47 -37) 📝 `src/lib/platform/XWindowsKeyState.h` (+7 -3) 📝 `src/lib/platform/XWindowsScreen.cpp` (+124 -152) 📝 `src/lib/platform/XWindowsScreen.h` (+4 -1) 📝 `src/lib/platform/XWindowsScreenSaver.cpp` (+49 -44) 📝 `src/lib/platform/XWindowsScreenSaver.h` (+5 -1) </details> ### 📄 Description First PR out of many for #76. Discussed and coordinated with @p12tic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>