[PR #157] [MERGED] Build full installer via clean_build.sh #1571

New issue

Closed

opened 2026-05-05 07:56:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/157
Author: @p12tic
Created: 10/18/2018
Status: ✅ Merged
Merged: 10/19/2018
Merged by: @AdrianKoshka

Base: master ← Head: osx-installer

📝 Commits (2)

fe1568f OSX: Fix lack of newlines in build messages
65b9fae OSX: Build full installer as part of the installer build via cmake

📊 Changes

3 files changed (+16 additions, -6 deletions)

View changed files

📝 CMakeLists.txt (+7 -0)
📝 dist/macos/bundle/build_installer.sh.in (+4 -1)
📝 osx_environment.sh (+5 -5)

📄 Description

Currently doing env B_BUILD_TYPE=Release ./clean_build.sh won't build full installer on OSX as build_installer.sh script won't be run. This PR reduces the possible confusion by including the installer into the regular build process handled by cmake. Tested the resulting dmg on all of OSX 10.12, 10.13 and 10.14.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/157 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 10/18/2018 **Status:** ✅ Merged **Merged:** 10/19/2018 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `osx-installer` --- ### 📝 Commits (2) - [`fe1568f`](https://github.com/debauchee/barrier/commit/fe1568f4cabcc36baf72b38bad02a16951435bd0) OSX: Fix lack of newlines in build messages - [`65b9fae`](https://github.com/debauchee/barrier/commit/65b9fae5dedc8d0926dde885ee12960f903c21b8) OSX: Build full installer as part of the installer build via cmake ### 📊 Changes **3 files changed** (+16 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+7 -0) 📝 `dist/macos/bundle/build_installer.sh.in` (+4 -1) 📝 `osx_environment.sh` (+5 -5) </details> ### 📄 Description Currently doing `env B_BUILD_TYPE=Release ./clean_build.sh` won't build full installer on OSX as build_installer.sh script won't be run. This PR reduces the possible confusion by including the installer into the regular build process handled by cmake. Tested the resulting dmg on all of OSX 10.12, 10.13 and 10.14. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>