[PR #140] [MERGED] gui: Fix auto hide behavior #1567

Closed
opened 2026-05-05 07:56:31 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/140
Author: @raymanfx
Created: 10/1/2018
Status: Merged
Merged: 10/13/2018
Merged by: @AdrianKoshka

Base: masterHead: master


📝 Commits (1)

  • 7b86ecc gui: Fix auto hide behavior

📊 Changes

1 file changed (+9 additions, -5 deletions)

View changed files

📝 src/gui/src/main.cpp (+9 -5)

📄 Description

  • make waitForTray() report a proper status - the return value was not
    used until now anyway (it would always return true)
  • depend on the system tray availability for auto hide

On my system (Fedora 29 with Pantheon Desktop), on a clean install the GUI
would auto hide itself on startup, but due to no system tray being
available I could never make the GUI appear again.

This change disallows auto hide if the system tray is not available.
Users who don't want the GUI can just start barriers/barrierc instead of
the main barrier executable, so this should not break existing workflows.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/140 **Author:** [@raymanfx](https://github.com/raymanfx) **Created:** 10/1/2018 **Status:** ✅ Merged **Merged:** 10/13/2018 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`7b86ecc`](https://github.com/debauchee/barrier/commit/7b86eccf02ab4a37b3a6f97ceabcb4660bfc3b02) gui: Fix auto hide behavior ### 📊 Changes **1 file changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/src/main.cpp` (+9 -5) </details> ### 📄 Description * make waitForTray() report a proper status - the return value was not used until now anyway (it would always return true) * depend on the system tray availability for auto hide On my system (Fedora 29 with Pantheon Desktop), on a clean install the GUI would auto hide itself on startup, but due to no system tray being available I could never make the GUI appear again. This change disallows auto hide if the system tray is not available. Users who don't want the GUI can just start barriers/barrierc instead of the main barrier executable, so this should not break existing workflows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:56:31 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1567
No description provided.