[PR #91] [CLOSED] [TEST ME!] Smarter Zeroconf Address #1563

New issue

Closed

opened 2026-05-05 07:56:25 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:25 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/91
Author: @walker0643
Created: 7/4/2018
Status: ❌ Closed

Base: master ← Head: smartzeroconf

📝 Commits (10+)

2d7818f better discovery of default IP address via ZeroConf
33224a1 drop Qt discovery of best IP address in favor of pure WINAPI method (with wireless detection)
a2b3658 add unix implementation for DefaultInterfaceIP
6761528 Merge pull request #90 from debauchee/master
b84202a change order of headers and leave out wireless checking on osx for now
30cce2d remove netinet/in.h
e2acbdb add net/if.h
a739ce7 reinsert netinet/in.h
b120fe4 only include net/if.h for bsd/osx
c9bd5c2 weed out inactive interfaces on windows

📊 Changes

10 files changed (+326 additions, -37 deletions)

View changed files

📝 src/gui/CMakeLists.txt (+16 -8)
➕ src/gui/src/DefaultInterfaceIP.h (+10 -0)
📝 src/gui/src/ZeroconfService.cpp (+2 -28)
📝 src/gui/src/ZeroconfService.h (+0 -1)
📝 src/gui/src/main.cpp (+7 -0)
➕ src/gui/src/unix/DefaultInterfaceIP.cpp (+79 -0)
➕ src/gui/src/unix/IfAddrsResource.h (+32 -0)
➕ src/gui/src/unix/SocketResource.h (+32 -0)
➕ src/gui/src/win32/DefaultInterfaceIP.cpp (+100 -0)
➕ src/gui/src/win32/HeapResource.h (+48 -0)

📄 Description

Ref: #81

Currently zeroconf code uses Qt libs for picking an IP address to advertise. While it is cross-platform it doesn't prefer real interfaces over virtual ones, nor wired over wifi. This PR fixes both of these issues.

I would like to have the Barrier community test the smartzeroconf branch. Everyone that can use Zeroconf please test with your setup and leave comments below.

If there are issues with detection please use this project as a diagnostic. Windows x64 users can use this link to download a prebuilt binary.

Thanks everyone!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/91 **Author:** [@walker0643](https://github.com/walker0643) **Created:** 7/4/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `smartzeroconf` --- ### 📝 Commits (10+) - [`2d7818f`](https://github.com/debauchee/barrier/commit/2d7818fe49ddc9b7d1a97b5afc643ee5f48790c8) better discovery of default IP address via ZeroConf - [`33224a1`](https://github.com/debauchee/barrier/commit/33224a1f974f27daa598ccd43d138d9e2a6d395c) drop Qt discovery of best IP address in favor of pure WINAPI method (with wireless detection) - [`a2b3658`](https://github.com/debauchee/barrier/commit/a2b365815ad3b1eaddaae41837155ba4f63b8930) add unix implementation for DefaultInterfaceIP - [`6761528`](https://github.com/debauchee/barrier/commit/6761528e0bf28731c432120e4336bd0a2c5d76a0) Merge pull request #90 from debauchee/master - [`b84202a`](https://github.com/debauchee/barrier/commit/b84202aa9a3f757bf0f1a8f895cadf26d07ad3b4) change order of headers and leave out wireless checking on osx for now - [`30cce2d`](https://github.com/debauchee/barrier/commit/30cce2dda2ae95b2421f5da1c218d7775d3e8a72) remove netinet/in.h - [`e2acbdb`](https://github.com/debauchee/barrier/commit/e2acbdb409b4daf57c4b476032c8eb73509a5b0f) add net/if.h - [`a739ce7`](https://github.com/debauchee/barrier/commit/a739ce784ad64fe4b4151c19340472f75ec1cbb7) reinsert netinet/in.h - [`b120fe4`](https://github.com/debauchee/barrier/commit/b120fe4d6707f1de2443663cab830968d982381f) only include net/if.h for bsd/osx - [`c9bd5c2`](https://github.com/debauchee/barrier/commit/c9bd5c2affc3364a2008abecdc72dcd4b83b38ea) weed out inactive interfaces on windows ### 📊 Changes **10 files changed** (+326 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/CMakeLists.txt` (+16 -8) ➕ `src/gui/src/DefaultInterfaceIP.h` (+10 -0) 📝 `src/gui/src/ZeroconfService.cpp` (+2 -28) 📝 `src/gui/src/ZeroconfService.h` (+0 -1) 📝 `src/gui/src/main.cpp` (+7 -0) ➕ `src/gui/src/unix/DefaultInterfaceIP.cpp` (+79 -0) ➕ `src/gui/src/unix/IfAddrsResource.h` (+32 -0) ➕ `src/gui/src/unix/SocketResource.h` (+32 -0) ➕ `src/gui/src/win32/DefaultInterfaceIP.cpp` (+100 -0) ➕ `src/gui/src/win32/HeapResource.h` (+48 -0) </details> ### 📄 Description Ref: #81 Currently zeroconf code uses Qt libs for picking an IP address to advertise. While it is cross-platform it doesn't prefer real interfaces over virtual ones, nor wired over wifi. This PR fixes both of these issues. I would like to have the Barrier community test the smartzeroconf branch. Everyone that can use Zeroconf please test with your setup and leave comments below. If there are issues with detection please use [this project](https://github.com/walker0643/defaultinterfaceip/) as a diagnostic. Windows x64 users can use [this link](https://github.com/walker0643/defaultinterfaceip/releases/download/R1/DefaultInterfaceIP.exe) to download a prebuilt binary. Thanks everyone! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>