[PR #59] [CLOSED] Port to Qt 5.11 #1550

New issue

Closed

opened 2026-05-05 07:56:11 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:11 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/59
Author: @jfmcarreira
Created: 6/15/2018
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

71926a2 Port to Qt 5.11

📊 Changes

3 files changed (+4 additions, -2 deletions)

View changed files

📝 src/gui/CMakeLists.txt (+2 -2)
📝 src/gui/src/ActionDialog.cpp (+1 -0)
📝 src/gui/src/ScreenSetupView.cpp (+1 -0)

📄 Description

This commit ports the code to be compatible with Qt 5.11.

In Qt 5.11 qt5_use_modules was removed and the correct way is by using target_link_libraries to link against the Qt modules.

Moreover, some implicit includes do not work now. I added the missing includes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/59 **Author:** [@jfmcarreira](https://github.com/jfmcarreira) **Created:** 6/15/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`71926a2`](https://github.com/debauchee/barrier/commit/71926a276123c307a74a78851b5eed70d069f3ed) Port to Qt 5.11 ### 📊 Changes **3 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/CMakeLists.txt` (+2 -2) 📝 `src/gui/src/ActionDialog.cpp` (+1 -0) 📝 `src/gui/src/ScreenSetupView.cpp` (+1 -0) </details> ### 📄 Description This commit ports the code to be compatible with Qt 5.11. In Qt 5.11 qt5_use_modules was removed and the correct way is by using target_link_libraries to link against the Qt modules. Moreover, some implicit includes do not work now. I added the missing includes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>