mirror of
https://github.com/airwindows/airwindows.git
synced 2026-05-15 06:05:55 -06:00
[GH-ISSUE #41] TapeDust for-loop condition always false #34
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/airwindows#34
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NeverKnewTheName on GitHub (Aug 2, 2022).
Original GitHub issue: https://github.com/airwindows/airwindows/issues/41
In TapeDustProc.cpp from the WinVST sources there is a for-loop that's never run due to its condition always evaluating to false:
for(int count = 9; count < 0; count--) { bL[count+1] = bL[count]; bR[count+1] = bR[count]; }count is set to 9 so it'll always be greater than 0, but the loop queries for count being less than 0 to continue.
i verified this issue by unrolling the loop and testing. turns out there's almost no effect when the loop actually repeats for 10 cycles.
@chmaha commented on GitHub (Feb 20, 2023):
I suspect all that needs to happen is change
count < 0tocount > 0. It would then follow similar lines in his code. I've created a pull request: https://github.com/airwindows/airwindows/pull/44