[GH-ISSUE #29] *in++; #22

Closed
opened 2026-05-05 22:02:03 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @sjaehn on GitHub (May 24, 2021).
Original GitHub issue: https://github.com/airwindows/airwindows/issues/29

Hi Chris,
first of all big compliments for your great plugin collection. I already follow you yt streams for a wile, if I can find time. Very educating.

Now my minor issue. But maybe I'm wrong. I was wondering that the process method code for (almost?) all your plugins contain the following block at the end of the while loop:

*in1++;
*in2++;
*out1++;
*out2++;

The de-referencer * is not required here as you don't assign anything to where in1 (and the others) point to. My compiler complains about it ([-Wunused-value]). But I think (hope) that compilers ignore this de-referencing that isn't used and it finally doesn't cost any CPU time or memory. Anyway, I would go with in1++; (and the others) without *.

Originally created by @sjaehn on GitHub (May 24, 2021). Original GitHub issue: https://github.com/airwindows/airwindows/issues/29 Hi Chris, first of all big compliments for your great plugin collection. I already follow you yt streams for a wile, if I can find time. Very educating. Now my minor issue. But maybe I'm wrong. I was wondering that the process method code for (almost?) all your plugins contain the following block at the end of the `while` loop: ``` *in1++; *in2++; *out1++; *out2++; ``` The de-referencer `*` is not required here as you don't assign anything to where `in1` (and the others) point to. My compiler complains about it ([-Wunused-value]). But I think (hope) that compilers ignore this de-referencing that isn't used and it finally doesn't cost any CPU time or memory. Anyway, I would go with `in1++;` (and the others) without `*`.
Author
Owner

@airwindows commented on GitHub (May 24, 2021):

These are parts of the code directly from the templates (I think in this case it'd be the VST code?)

I don't change stuff that's part of the template: I'm glad it's not failing to work, but I'm leaving it alone regardless as I didn't write that code. The platform designer had it that way, so I'm going to leave it consistent with how Apple or Steinberg wrote it when they wrote it :)

<!-- gh-comment-id:847335851 --> @airwindows commented on GitHub (May 24, 2021): These are parts of the code directly from the templates (I think in this case it'd be the VST code?) I don't change stuff that's part of the template: I'm glad it's not failing to work, but I'm leaving it alone regardless as I didn't write that code. The platform designer had it that way, so I'm going to leave it consistent with how Apple or Steinberg wrote it when they wrote it :)
Author
Owner

@sjaehn commented on GitHub (May 24, 2021):

OK, nice to know && fine for me.

<!-- gh-comment-id:847350894 --> @sjaehn commented on GitHub (May 24, 2021): OK, nice to know && fine for me.
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/airwindows#22
No description provided.