[GH-ISSUE #1809] App makes network requests even when "Automatically check for updates" is disabled #998

New issue

Closed

opened 2026-05-05 07:01:03 -06:00 by gitea-mirror · 1 comment

gitea-mirror commented

2026-05-05 07:01:03 -06:00

Owner

Originally created by @yungweng on GitHub (Oct 2, 2025).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/1809

Before opening the issue, have you...?

Searched for existing issues
Looked through the wiki
Updated MonitorControl to the latest version (if applicable)

Describe the bug

When the "Automatically check for updates" checkbox is unchecked in Preferences > General, MonitorControl continues to make network requests to monitorcontrol.app, github.com, and githubusercontent.com. Network monitoring software (firewall/network control tools) still shows these connection attempts despite the preference being disabled.

Steps to reproduce

Open MonitorControl Preferences
Go to 'General' tab
Uncheck 'Automatically check for updates'
Close preferences and restart the app
Monitor network activity with firewall/network control software
Observe connection attempts to monitorcontrol.app, github.com, and githubusercontent.com

Expected behavior

When "Automatically check for updates" is unchecked, the app should not make any network requests or initialize the Sparkle updater framework. Network activity should only occur when manually clicking "Check for updates" in the About preferences.

Anything else?

Root cause: AppDelegate.swift line 68 unconditionally calls updaterController.startUpdater()
regardless of the SUEnableAutomaticChecks preference setting. The checkbox only sets the
preference but doesn't prevent the updater from initializing and making network requests.

Suggested fix: Wrap line 68 in a conditional check:
if prefs.bool(forKey: PrefKey.SUEnableAutomaticChecks.rawValue) {
self.updaterController.startUpdater()
}

Environment Information (please complete the following information)

- macOS version: 26.0 (Sequoia/Beta)
  - Mac model: MacBook Pro (M3 Max, Mac15,9)
  - MonitorControl version: 4.3.2
  - Monitor(s): [DELL]
  - Apple Silicon/M1 (yes or no): yes (M3 Max)

Originally created by @yungweng on GitHub (Oct 2, 2025). Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/1809 ### Before opening the issue, have you...? - [x] Searched for existing issues - [x] Looked through [the wiki](https://github.com/MonitorControl/MonitorControl/wiki) - [x] Updated MonitorControl to the latest version (if applicable) ### Describe the bug When the "Automatically check for updates" checkbox is unchecked in Preferences > General, MonitorControl continues to make network requests to monitorcontrol.app, github.com, and githubusercontent.com. Network monitoring software (firewall/network control tools) still shows these connection attempts despite the preference being disabled. ### Steps to reproduce 1. Open MonitorControl Preferences 2. Go to 'General' tab 3. Uncheck 'Automatically check for updates' 4. Close preferences and restart the app 5. Monitor network activity with firewall/network control software 6. Observe connection attempts to monitorcontrol.app, github.com, and githubusercontent.com ### Expected behavior When "Automatically check for updates" is unchecked, the app should not make any network requests or initialize the Sparkle updater framework. Network activity should only occur when manually clicking "Check for updates" in the About preferences. ### Anything else? Root cause: AppDelegate.swift line 68 unconditionally calls `updaterController.startUpdater()` regardless of the SUEnableAutomaticChecks preference setting. The checkbox only sets the preference but doesn't prevent the updater from initializing and making network requests. Suggested fix: Wrap line 68 in a conditional check: if prefs.bool(forKey: PrefKey.SUEnableAutomaticChecks.rawValue) { self.updaterController.startUpdater() } ### Environment Information (please complete the following information) ```markdown - macOS version: 26.0 (Sequoia/Beta) - Mac model: MacBook Pro (M3 Max, Mac15,9) - MonitorControl version: 4.3.2 - Monitor(s): [DELL] - Apple Silicon/M1 (yes or no): yes (M3 Max) ```

gitea-mirror closed this issue

2026-05-05 07:01:05 -06:00

gitea-mirror commented

2026-05-05 07:01:09 -06:00

Author

Owner

@waydabber commented on GitHub (Oct 2, 2025):

This setting does not disable Sparkle in general, it just tells it not to inform the users about updates I think. But really this is a general Sparkle issue, I think you should report this there (why does it try to connect if it is set not to do)? But the issue might already be fixed in the latest Sparkle versions, not sure.

@waydabber commented on GitHub (Oct 2, 2025): This setting does not disable Sparkle in general, it just tells it not to inform the users about updates I think. But really this is a general Sparkle issue, I think you should report this there (why does it try to connect if it is set not to do)? But the issue might already be fixed in the latest Sparkle versions, not sure.