mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #121] Release with updated DCC.swift? #89
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#89
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danDanV1 on GitHub (Sep 12, 2019).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/121
reitermarkus/DDC.swift has been updated with a fix that should allow support for Acer monitors.
Based on update to kfix/ddctl which implement Fix signed/unsigned compare.
https://github.com/kfix/ddcctl/issues/53
@the0neyouseek Can you issue a release with the DCC.swift dependancy updated to latest commit?
41e7c49b04@danDanV1 commented on GitHub (Sep 14, 2019):
@JoniVR should I create a pull request for this? would you accept?
@JoniVR commented on GitHub (Sep 14, 2019):
I was planning on updating DDC.swift first thing when I get time. Then trying to merge in #116 and then create a release. I’ll try to get that done tomorrow but I can’t promise anything. But a PR is not really necessary since it’s should be pretty easy to do.
@JoniVR commented on GitHub (Sep 14, 2019):
Actually I think I’ll create a release before merging in #116 so we can get these critical fixes out faster.
@JoniVR commented on GitHub (Sep 15, 2019):
New release (v1.7.0) has been created. Please let me know if you run into any issues. I'm going to consider this closed in the meantime. :)
@danDanV1 commented on GitHub (Sep 15, 2019):
Nice. Works like a charm. Now I can finally control my Acer monitor!
BTW. Not a biggie, but the release wasn't signed with a developer ID. Gives the 'ol "can’t be opened because Apple cannot check it for malicious software" message.
@danDanV1 commented on GitHub (Sep 15, 2019):
and thank you!
@JoniVR commented on GitHub (Sep 15, 2019):
Thanks for letting me know, I think I forgot to notarize because I did sign it. I'll look into it later.
@JoniVR commented on GitHub (Sep 15, 2019):
Should be fixed now :)