mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #1398] App doesn't read brightness after waking up #792
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#792
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fidwj01 on GitHub (Jul 1, 2023).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/1398
Before opening the issue, have you...?
Describe the bug
When the screen wakes up from being off, changing the brightness from the MacBook keyboard won't update the app which causes "sync brightness" to not work. I've tried every options under "Upon startup or wake", nothing worked.
Restarting the app can fix the issue.
Steps to reproduce
Expected behavior
It should behave the same after the computer wakes up from sleep/display off.
Anything else?
No response
Environment Information (please complete the following information)
@Anywhere-Music-Player commented on GitHub (Jul 24, 2023):
Same here, also Volume reset too. When I change volume using keys - it sets to 0 in real, but still showing like it set.
And during this, changing volume do nothing - it always stays 0 in real value.
Restart of the app bring volume to normal value.
@stale[bot] commented on GitHub (Aug 2, 2024):
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require attention? This issue may be closed if no further activity occurs. Thank you for your contributions.
@Anywhere-Music-Player commented on GitHub (Aug 9, 2024):
@waydabber pls implement!
@waydabber commented on GitHub (Aug 9, 2024):
Hi @Volodymyr-13 - this should work in BetterDisplay. All MC features (and more) are available for free in BetterDisplay. I don't plan on any major future changes in MonitorControl 4 as it's code is very outdated by now.
@Anywhere-Music-Player commented on GitHub (Aug 9, 2024):
@waydabber i already told about it, it’s super overwhelmed app which is just hard to use for a basic needs. I will never use it.
so please update this app, thanks.
@waydabber commented on GitHub (Aug 9, 2024):
I understand your perspective. I might release a simplified version as MonitorControl 5 focusing only on brightness and volume control, if I get permission from the other maintainers to move forward with MonitorControl. Right now the consensus is that MC is done and I have no permission to take over the project alone. If this by any chance changes, it will be obvious. Sorry.
I don't see the point in creating a BetterDisplay Lite just to simplify an aspect of the app as that would be confusing + majority of users can live with the complexity or if they don't want to, they can simply turn off the offending menu items under Settings/Menu to make the app menu clean and simple. :) Making an app with an other name (other than MonitorControl or BetterDipslay) also seems like a bad idea, I don't want to start building an other "similar but still somewhat different" app from scratch under a different name trying to gather a suitable userbase for it.
@Anywhere-Music-Player commented on GitHub (Aug 9, 2024):
@waydabber just hide all nonsense and make your BetterDisplay same as this app.
I think you could add some landing options:
so if I chose basic, I will get like monitor control app in general, and also all overwhelmed menus structure will not be there.. oh my I even now trying to remember how I tried to navigate there.. that is madness.
@waydabber commented on GitHub (Aug 9, 2024):
I think by default the app simply shows the brightness and resolution slider only, all other menu items collapsed. This does not seem too complicated to me, but I understand we all have different perspectives.
If you want to see different things in the menu, please navigate to Settings > Menu > Customize Menu Options.
Or of course you can keep using MonitorControl 4, but please understand, I will not substantially update the app. I added basic Sequoia compatibility in an unofficial release - if it is required, I'll probably provide more such unofficial compatibility updates, but that's about it (note: I don't have the credentials required to build a version that can properly auto-update official builds). The unofficial build can be found here: https://github.com/waydabber/MonitorControl
@Anywhere-Music-Player commented on GitHub (Aug 9, 2024):
@waydabber
I just downloaded it and remove it, again. So the madness is here:
I have to scroll 4 screen pages of settings of monitor? Lol no thanks.
Vs just simplicity:
@waydabber commented on GitHub (Aug 9, 2024):
Right, if you intentionally open all Additional settings... blocks, then indeed, the Settings UI can get quite large. :) Also, the menu if you keep open the Tools section and unfold additional menus can get quite large. As for the onboarding and DDC configuration notifications, those go away as soon as you click on them at least once so you get to know how to use the app and let the app auto-configure DDC (you can of course do it manually as well).
But as I said, you can use either app, both are great and I live them both dearly, it's just that MonitorControl as it stands won't be developed further at least not officially - even if I wanted to develop it further, it's not entirely my decision anyway.
Thanks for all the feedback and take care! :)
@Anywhere-Music-Player commented on GitHub (Aug 9, 2024):
No no, you don't understand I'm not interested at all in figuring our what I have to..
I just don't need that because it's overwhelming. Period.
I'm thinking just asking from developer to rewrite this app from the ground up maybe.. since I don't need that madness overwhelming.
@waydabber commented on GitHub (Aug 9, 2024):
All right, thanks again for the feedback and perspective, I'll consider these inputs as I develop the app. For sure, you or any developer is free to fork MonitorControl (as it is open source) and improve upon it any way you find best suited to your needs. Just note that changes will probably not get to the official builds, but any number of unofficial builds can exist or even take over the original in popularity, no problem with that.
@fidwj01 commented on GitHub (Aug 9, 2024):
Thanks for the contribution. Just out of curiosity, why is the team abandoning this app and moved on to other similar app? And you mentioned there won't be new features added, but this is clearly a bug. Shouldn't it be fixed before we call it completed and leave it for good?
@waydabber commented on GitHub (Aug 9, 2024):
The original issue is that after wake, there is a wait period after the app reconfigures itself - during this period is disengaged from controlling the keyboard so the built in screen's brightness can be changed by the system itself through the normal keyboard control. It's just how MonitorControl was made and there is a valid reason for the delay. The behavior can be refined in many ways of course with further development - BetterDisplay has an option to change wake delay, configuration delay and also by default restores last saved brightness after wake or can update its setting based on changes the user made meanwhile. @Volodymyr-13's issue about volume is probably something else though.
I am not sure about the exact motivations of all team members, I guess everybody has other priorities now. For more context see this: https://www.reddit.com/r/mac/comments/1e30j3h/possible_limitation_of_monitorcontrol_development/?rdt=59029
@fidwj01 commented on GitHub (Aug 9, 2024):
I don't think what you described the delay is breaking it. If it's the delay, shouldn't it work after the delay is over? The problem is after wake, the app seems to lost what the displays are doing (basically the app doesn't know the changes made outside of it) until you restart MonitorControl. This is then breaking auto-brightness sync between the internal display and external display. Because the brightness of the internal display changes depending on ambient light, and MonitorControl doesn't know it when it does so it doesn't change the external display accordingly.
@waydabber commented on GitHub (Aug 9, 2024):
You mean the brightness change tracking is not resuming after wake? MonitorControl does it in a rather old fashioned way (basically there is a job that runs and regularly tracks the brightness changes from time A to time B and adjusts synced displays with some gentle curve accordingly - this is not the best way to do it actually, but at the time it was fine). Or it is that during this initial delay the sync is off and does not recover until the brightness is min/maxed or the slider is used? The app only does delta syncing from the built-in display to external displays (in BD you can have both absolute and delta + fine-tune how syncing works), so keeping an exact 1:1 match was not a design idea to begin with.
Either this or that, I don't think I'll work on this or try fixing it in any form as I believe everything should be rebuilt from the ground up differently - and I already did that in BetterDisplay, there is no inspiration to do it again trying to patch old code. What I'd do if MonitorControl was to be kept going is to start from the code of BetterDisplay, strip excess functionality and create a MonitorControl 5 from that. But for that to happen, a team decision must take place and in essence I'd take over the project - but this was not the consensus about how to move on and I am totally fine with that.
So I understand all of your feedback, really wish the best to all - I am also super happy if anybody steps up to improve MonitorControl in a fork - much like I did with my unofficial Sequoia compatible version. But probably it's time to face the fact that as things now stand, it is somewhat unlikely that the official MonitorControl project will have any future releases produced. The official version of the app crashes instantly on Sequoia on Macs with built-in displays, which means the official project is effectively sunsetting sooner than later.