mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 22:01:08 -06:00
[GH-ISSUE #1126] Monitor doesn't support mute, unable to set volume to 0 #664
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#664
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BenCorneau on GitHub (Jul 26, 2022).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/1126
Before opening the issue, have you...?
Describe the bug
Monitor: DELL U3419W
My monitor doesn't support the mute command
audioMuteScreenBlank = 0x8D. When the volume slider is set to 0% the volume on the actual monitor is set to 1%. This looks intentional to work around a bug with some monitorshttps://github.com/MonitorControl/MonitorControl/blob/main/MonitorControl/Model/OtherDisplay.swift#L493-L495
However, my monitor does support setting volume to 0, but doesn't support the mute command. My monitor's speaker also has the unfortunate characteristic of having a very loud 1% volume and very little dynamic range between 1% and 100%
I have a few thoughts on how this could be fixed, but realize they may be infeasible.
1 - use the "Enable mute DDC command" setting. If not enabled, then allow sending volume 0.
2 - In the DDC min / DDC max override config, if '0' is explicitly set, then allow sending volume 0. Perhaps this could clean up the special case for the audio 0 check in
convValueToDDCand 1 could be the default ddc min for the audio channel.3 - custom config overrides for specific device model numbers.
I'm happy to provide any additional detail and would be happy to submit a PR if you think one of the above options makes sense. I'd also be happy to try out any other suggestions either configuration or code changes to help out.
Steps to reproduce
using monitor
DELL U3419WExpected behavior
Expect the monitor to report a volume of 0%, but it is 1%
Anything else?
No response
Environment Information (please complete the following information)
@waydabber commented on GitHub (Jul 27, 2022):
Mute command is not used by default, unless
Enable Mute DDC commandis enabled. When this option is not clicked, the app is setting the volume level to 0 via DDC when the volume is set to 0%. If you still get sound and the display shows 1% then it seems like it does not oblige to the volume 0 command as well.You can try whether BetterDisplay or m1ddc works and can set the volume to 0 as these apps are using somewhat different implementations.
The mute compatibility issue has a long and complicated history so I don't think we'll reopen it anytime soon, but I'll convert this into a discussion. If you want, you can try changing the relevant parts of the code and experiment with it (you'll need XCode), I can direct you to the right place where you can make alterations.