mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #1026] Fine Scale (Alt+Shift) support with Custom Keybind #617
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#617
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @krackers on GitHub (May 5, 2022).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/1026
Before opening the issue, have you...?
Is your feature request related to a problem? Please describe
Currently, when using a custom shortcut (e.g. f10/f11) for volume up/down, toggling fine-scale via alt+shift does not seem to be supported like it is for the native volume keys.
Describe the solution you'd like
Ability to use a custom key, e.g. F11 for coarse volume and a modifier + custom, e.g. alt-shift-f11 for fine volume.
Describe alternatives you've considered
Considered patching
KeyboardShortcutsManager.swiftand building it myself although I'm not quite sure if MASShortcutRecorder supports passing through modifiers. Maybe another way to approach this would be to add separate keybind for the fine-scale.Anything else?
No response
@waydabber commented on GitHub (May 6, 2022):
Adding a separate shortcut would be the way to go as it is difficult to know what the custom key will be and whether it contains the key we'd regard as 'modifier' to begin with - in which case the modifier would fail.
@krackers commented on GitHub (May 6, 2022):
Thanks for the quick response, implemented this and it works pretty well! (Kudos on the well organized code-base by the way, was a pretty easy change).
Since the change is very simple probably no point in me opening a PR, and more importantly my change kind of hacked in the UI portion. The interaction between custom fine scale keybinding and the "use fine scale" checkbox needs to be considered. Probably using the tickbox should disable the possibility for separate fine-scale keybinds, although hypothetically someone may want to use fine-scale by default with the internal keyboard and have separate keybinding for an external keyboard.
Also a minor thing: to match the default OSD fine chiclets, the increment should probably be set to 1/64.0 instead of 0.01
@stale[bot] commented on GitHub (May 6, 2023):
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require attention? This issue may be closed if no further activity occurs. Thank you for your contributions.