mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #989] Control night shift intensity from MonitorControl #597
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#597
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Anywhere-Music-Player on GitHub (Apr 3, 2022).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/989
Before opening the issue, have you...?
Is your feature request related to a problem? Please describe
I'm looking for a % of currently set brightness. Also, I want to change Color Temperature.
Describe the solution you'd like
I forked and improved NativeDisplayBrightness app.
Initially it was without any UI. I added:
Can you please add such options in this amazing app? Thanks!
Describe alternatives you've considered
https://github.com/KAMIKAZEUA/NativeDisplayBrightness
Anything else?
No response
@waydabber commented on GitHub (Apr 7, 2022):
Hi @KAMIKAZEUA - congrats for modifying that app. Yes, we can do the same. MonitorControl already manages the gamma table (but for dimming only) so it would actually be quite easy to add color temperature control. It's a planned feature: https://github.com/MonitorControl/MonitorControl/issues/726
I don't know when will we get there though. But hey, MonitorControl is open source so if you are into Swift, you can add it yourself.
@waydabber commented on GitHub (Apr 7, 2022):
I'll close this one as a duplicate but will copy over your comment to that thread since your implementation might be useful in this effort. You can comment there as well! Thank you!
@Anywhere-Music-Player commented on GitHub (Apr 7, 2022):
Hey @waydabber actually in my app it's modifying by native system, so it changes system parameter:
I'm Objective C only.. swift is really strange language for me..
@Anywhere-Music-Player commented on GitHub (Apr 7, 2022):
And maybe this is my fault, since I asked about two features in one request.
Should I post another for: "I'm looking for a % of currently set brightness." ?
@waydabber commented on GitHub (Apr 7, 2022):
Ohh, right. We can implement modifying the system slider as well but the goal was to make something that works for TVs too where Night Shift is disabled. I'll reopen this one then as a separate request then.
as per your other question, you can see the % here:
You can enable this in Preferences in the
App Menusection.@Anywhere-Music-Player commented on GitHub (Apr 7, 2022):
Hmm, I’m not really got the point of .. for TV’s. You mean TV connected to any Mac? Night shift modify system video signal(if I can say like that) so any device will be with it.
and regarding %, I mean exactly in Status Bar icon, like in my app, so I can see brightness % all the time. :)
@waydabber commented on GitHub (Apr 7, 2022):
Night Shift modifies the gamma table at top level but it does not affect the signal directly and should technically work on TVs - but Apple intentionally disabled NightShift for various devices including TVs. This is bad news for the TV as Monitor crowd out there.
@waydabber commented on GitHub (Apr 7, 2022):
For the % in the menu bar, that is also possible, but you should create a separate feature request for that. :)
@ale-dd commented on GitHub (Aug 16, 2022):
I'd prefer something closer to Flux rather than relying on Apple's night shift - which doesn't filter out blue light at all.
Sometimes it'd be useful to let a small amount of blue light through, for a very short amount of time, when one cannot properly see some details. Letting just a bit of blue light through would be better than the only option Flux gives us in such a situation (i.e. completely disabling it).
@waydabber commented on GitHub (Aug 26, 2022):
Currently I am not sure if this feature will be implemented in MonitorControl anytime soon as it seems to me the app already reached (or in several ways exceeded) it's original vision/scope and to there is a feeling among team members that there should not be any further added complexity (instead maybe simplification for better maintainability in the future).
If you are seeking for this feature, BetterDisplay might be an alternative - it has the NightShift intensity slider as well as colortable based temperature control (much like f.lux). BetterDisplay can also enable NightShift for TVs.
NightShift slider:
Colortable temperature slider:
Enable NightShift for TVs:
(Since BD is a solo project of mine, there are no constraints on added complexity, I can make it as bloated as I want until my head explodes when I try to fix something... Important to note however that BD is not opensource, some features require Pro license + some find the app a bit intimidating with all its various current and planned features.)
@stale[bot] commented on GitHub (Sep 3, 2023):
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require attention? This issue may be closed if no further activity occurs. Thank you for your contributions.
@Anywhere-Music-Player commented on GitHub (Sep 3, 2023):
@waydabber I just pointed that my simple at has it functionality which is based on a system.
I'd like this be implemented in Monitor Control too. THanks!
@waydabber commented on GitHub (Sep 3, 2023):
Hi @Volodymyr-13 - you are free to fork the project and work on it if you'd like + also create a pull request. I'll approve it if it works fine!
@Anywhere-Music-Player commented on GitHub (Sep 3, 2023):
Hey @waydabber as I previously told I'm Objective C only.. swift is really strange language for me..
Also, I’m done with programming ~3 years ago.. I was just hoping that for a guy who knows project it would be very easy to use my project code or as example to implement this.. tiny functionality :)
@waydabber commented on GitHub (Sep 3, 2023):
Hi @Volodymyr-13 - I did implement it in BetterDisplay (albeit completely differently as it had to comply with the control system of the app). Unfortunately I don't think this will be in MonitorControl as the team decided a while ago that the app is already bloated compared to the original very simple vision (this is mainly due to my activities. :)) so no more features should be added - I would not want to defy that decision, I mostly focus on BetterDisplay where I already implemented this. :)
@Anywhere-Music-Player commented on GitHub (Oct 24, 2023):
@waydabber today again I tried BetterDisplay.
It feels so so so much over complicated! Maybe for someone who requires all it's functionality it's OK, but for me it's a super overwhelming!
I just change brightness and volume, thats almost it.. well yea, and this another more function would be cool - control Night Shift color.
Can you please just add a simple slider?
This is crazy easy peasy for developer who works on this app.
https://github.com/Volodymyr-13/NativeDisplayBrightness/blob/master/NativeDisplayBrightness/CBBlueLightClient.h
Just implement a couple of methods, thats it! Add slider ui, add option, done. 15 min for a developer who know this app...
@waydabber commented on GitHub (Oct 24, 2023):
I am afraid this is not possible. The team decided that MonitorControl proper is already too complex with regard to its original vision and no more features will be added (except maybe bug fixes). I might create a simplified version of BetterDisplay (BetterBrightness maybe?) in the future or create a MonitorControl 5 based on BetterDisplay under a different repo - but these are just dim ideas. BetterDisplay is fully customizable, if you don't need the extra functionality, simply turn it off under Settings/Menu/Customize App Menu Contents...
@Anywhere-Music-Player commented on GitHub (Oct 24, 2023):
But why so simple task is not possible? I'm thinking just fiverr'ing it for 5$ and some guy from Pakistan or India will do..
BetterBrightness sound good, and I think it's already good and also for modern displays any software manipulation is not needed, software dimming like, so this feature I'd remove totally. Other is perfect and nothing else is needed.
Menu and structure of items and everything in just a Settings of that app is crazy complicated, hard to navigate, I hate it.
@Anywhere-Music-Player commented on GitHub (Oct 25, 2023):
@waydabber or maybe at leats you can share some code or branch where this was try of implementation of this func?
So I can continue and finish it?