mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #748] Change menu icon #488
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#488
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Oct 28, 2021).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/748
Before opening the issue, have you...?
Is your feature request related to a problem? Please describe
Improvements
Describe the solution you'd like
I'd like to change the brightness icon to a speaker icon like the original Mac.
Maximal super would still be a simple equalizer function. Thanks :)
Describe alternatives you've considered
eqMac
Anything else?
No response
@JoniVR commented on GitHub (Oct 28, 2021):
Hi,
Equalizer seems a bit out-of-scope to me for MonitorControl. The icon could be done, but depends on what others think? Shouldn't be a setting imo but we can change the default.
@waydabber commented on GitHub (Oct 28, 2021):
Honestly I don't see how the equalizer could be implemented without diverting way out-of-scope (an audio filter device must be implemented for that which is a more serious undertaking and others already did that).
Regarding the icon, this indeed could be done (something maybe like to "Show Speaker icon if only volume control is active" or we could add a few alternate icons to select from - Speaker icon, Display icon, etc), but this would alter a signature part of the app and might create some minor confusion so I am unsure about this.
If we want to change the default icon, I don't see how a Speaker icon as a default would fit the app profile and both a Speaker or a Display icon could easily be confused with the similar native control center icons which many users also prefer to have (and it looks rather silly to have two icons of the same kind in the Menu bar). I personally rather like the current brightness/sun icon. :)
@JoniVR, you should decide. :)
BTW - the icon can be changed in XCode with minimal effort (we could provide some step-by-step instructions) if somebody really wishes to customize the MonitorControl experience. :) Alternatively, we could add a silent override option for it which could be edited in the preferences plist file. The tinkerer then could override the icon by specifying an alternate SF Symbol id string.
@cprcrack commented on GitHub (Nov 18, 2021):
This would be great. I initially used MonitorControl just to be able to change the volume of my monitor, which is basically my main volume, so having a "brightness" icon is really strange to me. If we cannot customize the icon, why not choose an icon that at least have both symbols, the sun and the speaker, which better represents both main MonitorControl's functions?
@Nudeladder commented on GitHub (Nov 28, 2021):
So, I am also wanting to change the menu bar icon into a more solid, bulkier one so that I can see it better, but I fumbled around in the contents folder but couldn't find it...I guess you can only change it using Xcode?
@waydabber commented on GitHub (Nov 28, 2021):
Yes, you can change the icon in XCode.
Search the project for
sun.maxand replace this string to an other SFSymbol (download the app to browse).Hope this helps!
@JoniVR commented on GitHub (Dec 3, 2021):
I really don't see how this is a big issue. Seems like yeah "nice to have" for a few users I guess.. Going to close it now. If you want a custom icon, you can always fork/modify the code and change it there.