mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #733] "Apply last saved values to display" not working #482
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#482
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @waydabber on GitHub (Oct 21, 2021).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/733
Originally assigned to: @waydabber on GitHub.
Discussed in https://github.com/MonitorControl/MonitorControl/discussions/732
Originally posted by terabyte128 October 21, 2021
I just downloaded version 4.0.0 RC1 and I'm trying to use the "Apply last saved values to display" setting for an external monitor that doesn't preserve brightness after it shuts off. But it doesn't seem to be working. When I open the menu var icon for MonitorControl, it shows the correct brightness but the display doesn't actually update until I click on the slider bar.
Is there something I need to do to allow MonitorControl to monitor wake events? Or something else I'm missing?
For some more context: when I unplug the monitor then plug it back in, the brightness is set correctly. The issue only occurs upon wake from sleep. I'm not sure whether this is a bug or just a mistake on my part, so I'm happy to file a bug if it's the former case :)
Thanks.
@waydabber commented on GitHub (Oct 21, 2021):
Hey @terabyte128 - indeed, this function works rather unrealiably. If the display is too slow to wake, MonitorControl might send the DDC restore command too early. I was able to reproduce this issue. I'll look into it.
@terabyte128 commented on GitHub (Oct 21, 2021):
Thank you @waydabber! Let me know if there's anything I can do to help (though, I don't have much experience with Swift).
@waydabber commented on GitHub (Oct 21, 2021):
I am trying to fix this. Not easy though because of the inherent uncertainity regarding how various dispalys wake and when do they start receiving and applying DDC commands. What I am trying to do is if
Apply last saved values to displayis enabled, the app will issue DDC commands for about 10 more seconds every second (after the initial delay after sleep) - hopefully this will be enough to force the display to apply changes. This small change needs a lot of rework though.If I committed the updated code to the
experimentalbranch, you can help testing it if you can build the app via XCode to see if it works with your config (alternatively I can provide an unsigned build).@terabyte128 commented on GitHub (Oct 21, 2021):
Sure, I'd be happy to try and test. I do have Xcode installed.
@waydabber commented on GitHub (Oct 21, 2021):
Hey, I pushed an update to the experimental branch. Hopefully it will work (and will not break other stuff). If you were able to test it, let me know!
After sleep, there is a 5 second wait period, after that (depending on the depth of the sleep) a full display reconfiguration and then for 10 seconds you should see 10 additional attempts every second as the app tries to restore DDC luminance (and contrast if enabled). Volume is not affected (as it would annoyingly pop-up an OSD on LG displays).
You should see something like this in the console:
The display should be fully wake between the 5-15 seconds period after initiating wake this time and should receive the proper command. If the display cannot wake up in 15 seconds then it will not work (the period could of course be extended).
Thank you!
@terabyte128 commented on GitHub (Oct 22, 2021):
I was able to confirm that this fixed the issue – thank you! It looks like my display picks up on the update on the second or third try.
@waydabber commented on GitHub (Oct 22, 2021):
Great! Thanks for the testing! :)