mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 22:01:08 -06:00
[GH-ISSUE #666] Contrast currently defaults to 100% and it gets applied upon wake when 'Apply last saved values to the display' is selected #458
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#458
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @waydabber on GitHub (Oct 4, 2021).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/666
Originally assigned to: @waydabber on GitHub.
Before opening the issue, have you...?
Describe the bug
If contrast is not read from the display it currently defaults to 100% if the user does not override it manually - which might not happen since contrast control is not enabled by default. When 'Apply last saved values to the display' is selected, this 100% is being written to the display upon startup or wake. This is confusing.
Steps to reproduce
See description.
Expected behavior
If contrast is undefined, it should be left undefined and should not be written on wake/startup - the best would be a neutral behavior in general if reading is not enabled - until the user does not attempt to change contrast intentionally, it should not be initialized or applied ever - if the user enables the slider or attempts to change contrast via keyboard, then a default of 75% should be implied if no contrast data is read from the display.
Alternatively, simply a common 75% contrast default should be applied instead of 100%. Current defaults for brightness 100% and volume 12,5% should remain as they are.
Anything else?
n/a
Environment Information (please complete the following information)
@waydabber commented on GitHub (Oct 4, 2021):
I changed the default to 75% in the latest PR but a better approach is to make the app register if contrast is actually ever touched and act accordingly. This still needs some work.
@waydabber commented on GitHub (Oct 5, 2021):
The app now registers if a DDC setting is ever changed by the user (
isTouched) and writes only touched values whenApply last saved values to the displayis enabled. If a command is touched, it can only be untouched with a preferences reset.