[GH-ISSUE #448] Fix dependencies #358

Closed
opened 2026-05-05 05:49:42 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @JonasGessner on GitHub (May 27, 2021).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/448

  • I have searched for existing issues
  • I have looked through the wiki
  • I have updated MonitorControl to the latest version

Describe the bug
I tried cloning the project and building it myself and I ran into several issues all boiling down to the fact that the Cartfile has no versions/commit hashes set:

  • AMCoreAudio is not called SimplyCoreAudio on version 4 and no longer source compatible with version 3 (AMCoreAudio) which is what this project uses. So the Cartfile should specify the version as ~> 3.4.
  • DDC and MediaKeyTap simply use master in the Cartfile. This is an issue because after I fixed the AVMCoreAudio problem I noticed that the app I compiled myself doesn't work properly – most of the time nothing changes on my display. Only after spamming volume/brightness keys anything starts to change. The latest version installed through homebrew does not have this problem. This could be a regression in DDC, but since there is no commit information/tag version for DDC in the Cartfile I do not know which commit you linked against!

Environment Information (please complete the following information):

  • macOS version: 11.4
  • Mac model: 2019 MBP
  • MonitorControl version: master
  • Monitor(s): LG HDR 5K
  • Apple Silicon/M1 (yes or no): no
Originally created by @JonasGessner on GitHub (May 27, 2021). Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/448 - [x] I have searched for existing issues - [x] I have looked through [the wiki](https://github.com/MonitorControl/MonitorControl/wiki) - [x] I have updated MonitorControl to the latest version **Describe the bug** I tried cloning the project and building it myself and I ran into several issues all boiling down to the fact that the Cartfile has no versions/commit hashes set: - AMCoreAudio is not called SimplyCoreAudio on version 4 and no longer source compatible with version 3 (AMCoreAudio) which is what this project uses. So the Cartfile should specify the version as `~> 3.4`. - DDC and MediaKeyTap simply use `master` in the Cartfile. This is an issue because after I fixed the AVMCoreAudio problem I noticed that the app I compiled myself doesn't work properly – most of the time nothing changes on my display. Only after spamming volume/brightness keys anything starts to change. The latest version installed through homebrew does not have this problem. This could be a regression in `DDC`, but since there is no commit information/tag version for DDC in the Cartfile I do not know which commit you linked against! **Environment Information (please complete the following information):** - macOS version: 11.4 - Mac model: 2019 MBP - MonitorControl version: master - Monitor(s): LG HDR 5K - Apple Silicon/M1 (yes or no): no
gitea-mirror 2026-05-05 05:49:42 -06:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@JoniVR commented on GitHub (May 27, 2021):

Hi, all of this is being worked on in the refactor/Preferences branch.

I just need to fix some of the storyboard stuff and it'll be ready for a merge.

Changes so far:

  • Migrated Carthage to SPM
  • Migrated MASPreferences To Preferences
  • AMCoreAudio to SimplyCoreAudio
  • Dependency updates in general

The switch to SPM also resolved command reliability, I have no idea why but I suspect it has something to do with Carthage.

So I suggest you work off that branch if you want to make changes, though I will probably squash merge it, it shouldn't be an issue.

<!-- gh-comment-id:849976730 --> @JoniVR commented on GitHub (May 27, 2021): Hi, all of this is being worked on in the refactor/Preferences branch. I just need to fix some of the storyboard stuff and it'll be ready for a merge. Changes so far: - Migrated Carthage to SPM - Migrated MASPreferences To Preferences - AMCoreAudio to SimplyCoreAudio - Dependency updates in general The switch to SPM also resolved command reliability, I have no idea why but I suspect it has something to do with Carthage. So I suggest you work off that branch if you want to make changes, though I will probably squash merge it, it shouldn't be an issue.
Author
Owner

@JonasGessner commented on GitHub (May 27, 2021):

That's great, thanks for the quick reply!

<!-- gh-comment-id:849982013 --> @JonasGessner commented on GitHub (May 27, 2021): That's great, thanks for the quick reply!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/MonitorControl#358
No description provided.