[GH-ISSUE #331] Brightness on another VCP code #262

Closed
opened 2026-05-05 05:38:37 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @Giacomo-Sanna on GitHub (Nov 22, 2020).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/331

Checklist

  • I have searched for existing issues

Question
When I try to change the brightness of the monitor, the black level is changed instead.
After some researches, I discovered that my monitor isn’t following the last VESA Monitor Control Command Set standard.
Basically to change the monitor brightness you set inDDC.swift
case luminance = 0x10
but for my monitor I need to set it to 0x13.
I was wondering if I need to build the project with my changes, or I can edit something in the .dmg file.

Originally created by @Giacomo-Sanna on GitHub (Nov 22, 2020). Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/331 **Checklist** <!-- Before you submit your issue, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> - [x] I have searched for existing issues **Question** When I try to change the brightness of the monitor, the black level is changed instead. After some researches, I discovered that my monitor isn’t following the last VESA Monitor Control Command Set standard. Basically to change the monitor brightness you set in`DDC.swift` `case luminance = 0x10` but for my monitor I need to set it to `0x13`. I was wondering if I need to build the project with my changes, or I can edit something in the .dmg file.
Author
Owner

@JoniVR commented on GitHub (Nov 22, 2020):

Yes, you'd probably want to create a fork of this project, change the value to .backlightControlLegacy (0x13) and then build it yourself. I think we could also provide this as an advanced preferences option in the future, but that's probably a long way off unless you'd want to implement it in a PR.

<!-- gh-comment-id:731779939 --> @JoniVR commented on GitHub (Nov 22, 2020): Yes, you'd probably want to create a fork of this project, change the value to `.backlightControlLegacy` (0x13) and then build it yourself. I think we could also provide this as an advanced preferences option in the future, but that's probably a long way off unless you'd want to implement it in a PR.
Author
Owner

@Giacomo-Sanna commented on GitHub (Nov 22, 2020):

Thanks, I'll do it myself.
But in the future, if you will develop it, it would be great.

<!-- gh-comment-id:731781296 --> @Giacomo-Sanna commented on GitHub (Nov 22, 2020): Thanks, I'll do it myself. But in the future, if you will develop it, it would be great.
Author
Owner

@JoniVR commented on GitHub (Dec 5, 2020):

If you want it in, you or someone else will have to submit a Pull Request.

You can't expect maintainers to do all the work, that's not a sustainable approach for any of us as this is in no way something we do full-time.

I'm open to merging it as an Advanced preferences feature if anyone is willing to submit it. Closing for now, feel free to reopen or ping me to reopen 🙂

<!-- gh-comment-id:739083494 --> @JoniVR commented on GitHub (Dec 5, 2020): If you want it in, you or someone else will have to submit a Pull Request. You can't expect maintainers to do all the work, that's not a sustainable approach for any of us as this is in no way something we do full-time. I'm open to merging it as an Advanced preferences feature if anyone is willing to submit it. Closing for now, feel free to reopen or ping me to reopen 🙂
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/MonitorControl#262
No description provided.