mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #331] Brightness on another VCP code #262
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Giacomo-Sanna on GitHub (Nov 22, 2020).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/331
Checklist
Question
When I try to change the brightness of the monitor, the black level is changed instead.
After some researches, I discovered that my monitor isn’t following the last VESA Monitor Control Command Set standard.
Basically to change the monitor brightness you set in
DDC.swiftcase luminance = 0x10but for my monitor I need to set it to
0x13.I was wondering if I need to build the project with my changes, or I can edit something in the .dmg file.
@JoniVR commented on GitHub (Nov 22, 2020):
Yes, you'd probably want to create a fork of this project, change the value to
.backlightControlLegacy(0x13) and then build it yourself. I think we could also provide this as an advanced preferences option in the future, but that's probably a long way off unless you'd want to implement it in a PR.@Giacomo-Sanna commented on GitHub (Nov 22, 2020):
Thanks, I'll do it myself.
But in the future, if you will develop it, it would be great.
@JoniVR commented on GitHub (Dec 5, 2020):
If you want it in, you or someone else will have to submit a Pull Request.
You can't expect maintainers to do all the work, that's not a sustainable approach for any of us as this is in no way something we do full-time.
I'm open to merging it as an Advanced preferences feature if anyone is willing to submit it. Closing for now, feel free to reopen or ping me to reopen 🙂