mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #274] Touchbar support #214
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @galambosmisi on GitHub (Aug 12, 2020).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/274
Originally assigned to: @waydabber on GitHub.
Checklist
Issue description
I installed the app. It works well from the menu bar and with the extended touch bar where all the standard funcion keys simulated on it.
But if I want to control the brightness of the external display with the "closed" touch bar, only the built-in screen is set by the application, even if the external monitor is active.
Expected behavior
I want to change the brightness of the active monitor with the "closed" TouchBar brightness controller button.
Environment Information:
@alex955 commented on GitHub (Jan 1, 2021):
Why is this close? I only change my brightness with the compact Touch Bar. I would love to have this feature.
@JoniVR commented on GitHub (Jan 1, 2021):
@alex955 it's not closed 🙂
@agrml commented on GitHub (Jan 19, 2021):
First of all, I wanna thank the author for that amazing app! I thought that I have to buy an apple display to control it's brightness over mac's keyboard. Now I don't have to!)
Secondary, slider doesn't work on my Mac Pro (16, 2019) Catalina 10.15.7 (19H114). And it would be awesome if it were!
@waydabber commented on GitHub (Aug 20, 2021):
This could be done in a tricky way. We can't read the touch bar slider directly but the slider controls the internal display brightness and we have the ability to read the internal display brightness via
DisplayServicesGetBrightness(). This would need a constant polling however whether the brightness changed or not (but it would probably not drain the system too much). Unfortunatelly I don't actually have an MBP as I decidedly hated the Touchbar so I can't experiment with this. Just shared my suggested route to fix this if somebody has the will to do it. But this issue is essentially the same as polling and adjusting the brightness changes caused by the built in light sensor changes: https://github.com/MonitorControl/MonitorControl/issues/27@agrml commented on GitHub (Aug 23, 2021):
Polling is definitely implemented here: https://github.com/alin23/Lunar
@waydabber commented on GitHub (Aug 23, 2021):
All right, I'll talk to @alin23 about this if he figured out how to have direct access to the touchbar slider (he has an MBP so he probably had the chance to work on that a lot if it is possible), but polling through getting the actual internal display brightness should be fine.
@alin23 commented on GitHub (Aug 23, 2021):
@waydabber @agrml Lunar polls the built-in display brightness, it has no knowledge whatsoever about the Touchbar slider.
@waydabber commented on GitHub (Aug 23, 2021):
Thanks @alin23!
@JoniVR commented on GitHub (Aug 23, 2021):
For future reference: if we want to debug the touchbar without physically having one, we still can:
Window > Touch Bar > Show Touch Bar
@waydabber commented on GitHub (Aug 26, 2021):
Since the touch bar support probably won't be achievable on its own, let's continue talking about this issue here:
#27
@waydabber commented on GitHub (Sep 19, 2021):
Brightness change synchronization from Built-In and Apple displays to other displays is now added. This makes Touch Bar, Ambient light sensor, Control Center and System Preferences induced changes affect all displays. Synchronization is not direct, but only changes are replicated - the user can intervene and adjust at any time.
https://github.com/MonitorControl/MonitorControl/discussions/596
https://github.com/MonitorControl/MonitorControl/issues/27