[GH-ISSUE #255] String Consistency #197

New issue

Closed

opened 2026-05-05 05:22:55 -06:00 by gitea-mirror · 3 comments

gitea-mirror commented

2026-05-05 05:22:55 -06:00

Owner

Originally created by @reustle on GitHub (Jul 10, 2020).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/255

I could be wrong, but these strings could be uniformly capitalized.

This one seems fine: 9fd78dc17f/MonitorControl/UI/en.lproj/Main.strings (L54)

We could lowercase "Login" here.
9fd78dc17f/MonitorControl/UI/en.lproj/Main.strings (L30)

We could lowercase "Brightness" and "Contrast" here
9fd78dc17f/MonitorControl/UI/en.lproj/Main.strings (L24)

Thoughts?

Originally created by @reustle on GitHub (Jul 10, 2020). Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/255 <img width="291" alt="image" src="https://user-images.githubusercontent.com/304560/87131815-ee48f900-c2cf-11ea-9506-fdc7794cd8a7.png"> I could be wrong, but these strings could be uniformly capitalized. This one seems fine: https://github.com/MonitorControl/MonitorControl/blob/9fd78dc17fe16dc9a6e05c66364a87c874285f4b/MonitorControl/UI/en.lproj/Main.strings#L54 We could lowercase "Login" here. https://github.com/MonitorControl/MonitorControl/blob/9fd78dc17fe16dc9a6e05c66364a87c874285f4b/MonitorControl/UI/en.lproj/Main.strings#L30 We could lowercase "Brightness" and "Contrast" here https://github.com/MonitorControl/MonitorControl/blob/9fd78dc17fe16dc9a6e05c66364a87c874285f4b/MonitorControl/UI/en.lproj/Main.strings#L24 Thoughts?

gitea-mirror closed this issue

2026-05-05 05:22:56 -06:00

gitea-mirror commented

2026-05-05 05:22:58 -06:00

Author

Owner

@the0neyouseek commented on GitHub (Jul 10, 2020):

Please feel free to open a Pull resquest for this changes :)

@the0neyouseek commented on GitHub (Jul 10, 2020): Please feel free to open a Pull resquest for this changes :)

gitea-mirror commented

2026-05-05 05:23:00 -06:00

Author

Owner

@reustle commented on GitHub (Jul 10, 2020):

@the0neyouseek Happy to do so, but I've never done xcode dev before. I'm guessing it isn't as easy as changing this file, but also doing some building / compiling?

@reustle commented on GitHub (Jul 10, 2020): @the0neyouseek Happy to do so, but I've never done xcode dev before. I'm guessing it isn't as easy as changing this file, but also doing some building / compiling?

gitea-mirror commented

2026-05-05 05:23:02 -06:00

Author

Owner

@the0neyouseek commented on GitHub (Jul 10, 2020):

No need if you’re just changing strings 😊. You can simply edit the file (even directly in github if you don’t want to download the whole project)

@the0neyouseek commented on GitHub (Jul 10, 2020): No need if you’re just changing strings 😊. You can simply edit the file (even directly in github if you don’t want to download the whole project)