mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #238] DDC commands not being issued reliably when building with Xcode > 11.3.1 #185
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#185
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JoniVR on GitHub (Jun 10, 2020).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/238
On recent versions of Xcode, I get some reliability issues with DDC in MonitorControl. I'm not sure why this is happing but I'm wondering if anyone else is running into this too.
Note: I haven't tested all the versions after 11.3.1 but current last version (11.5 and the one version below that don't work for me).
@realav commented on GitHub (Aug 15, 2020):
I can confirm that keys are not working when built with Xcode 11.6, although works fine on Xcode 11.3.1.
@JoniVR commented on GitHub (Aug 15, 2020):
Glad to know someone else noticed this too. Commands are working intermittently but not consistently. Should really test if it's a DDC.swift issue.
@JoniVR commented on GitHub (Oct 3, 2020):
I just went back to test some more, DDC commands are not being issues consistently when using keys on version 11.4 and up. I'm pretty sure commands are being sent to DDC but the display values are not always being updated.
@reitermarkus, could you please test if this also happens for you if you have time? I ran the tests on your DDC.swift repo and everything seems fine, commands mostly work when dragging using the slider.
Using shortcuts or clicking in the slider to instantly change the value doesn't work.
@JoniVR commented on GitHub (Nov 22, 2020):
DDC.swift issue can be resolved by including the DDC.swift framework manually and then removing the
serialNumberfunction fromEDID+Extension.swiftas it seems to conflict somewhere. Will dig into why this is happening soon but at least we have a general idea of what it could be.@Takuro-Ito commented on GitHub (Apr 10, 2021):
I just found out that
func valueChanged(slider: NSSlider)inSliderHandler.swiftis called multiple times (mostly 3 to 5 times for dragging) and it works fine using the slider.So I modified code in
override func stepBrightness(isUp: Bool, isSmallIncrement: Bool)inExternalDisplay.swiftlike this and it works fine using key tap.But I don't think this is a legitimate solution and don't know why Xcode built
DDC.swiftworks fine without sending commands multiple times on a key tap.Any ideas? @JoniVR @reitermarkus