[PR #1908] Add in-app language selection #1330

New issue

Open

opened 2026-10-02 22:09:50 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-10-02 22:09:50 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/1908
Author: @fatihdurmaz
Created: 9/20/2026
Status: 🔄 Open

Base: main ← Head: feature/in-app-language-selection

📝 Commits (1)

fbfa776 Add in-app language selection

📊 Changes

3 files changed (+112 additions, -0 deletions)

View changed files

📝 MonitorControl/UI/en.lproj/Localizable.strings (+18 -0)
📝 MonitorControl/UI/tr.lproj/Localizable.strings (+18 -0)
📝 MonitorControl/View Controllers/Preferences/MainPrefsViewController.swift (+76 -0)

📄 Description

Summary

Adds an in-app language picker to the General settings pane.

Changes

Lists all localizations bundled with MonitorControl
Adds a System Default option
Stores the selected language as an app-specific preference
Prompts the user to restart MonitorControl after changing the language
Adds English and Turkish localizations for the new UI

Testing

Confirmed there are no compiler diagnostics in MainPrefsViewController.swift
Confirmed the project builds successfully in Xcode
Verified the PR contains only the three files related to this feature

Implementation note

The selected language is persisted in the app domain through the AppleLanguages preference and takes effect on the next launch.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/1908 **Author:** [@fatihdurmaz](https://github.com/fatihdurmaz) **Created:** 9/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature/in-app-language-selection` --- ### 📝 Commits (1) - [`fbfa776`](https://github.com/MonitorControl/MonitorControl/commit/fbfa776d099e057969fdc2fef4c57179a86ebf4c) Add in-app language selection ### 📊 Changes **3 files changed** (+112 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/UI/en.lproj/Localizable.strings` (+18 -0) 📝 `MonitorControl/UI/tr.lproj/Localizable.strings` (+18 -0) 📝 `MonitorControl/View Controllers/Preferences/MainPrefsViewController.swift` (+76 -0) </details> ### 📄 Description ## Summary Adds an in-app language picker to the General settings pane. ## Changes - Lists all localizations bundled with MonitorControl - Adds a **System Default** option - Stores the selected language as an app-specific preference - Prompts the user to restart MonitorControl after changing the language - Adds English and Turkish localizations for the new UI ## Testing - Confirmed there are no compiler diagnostics in `MainPrefsViewController.swift` - Confirmed the project builds successfully in Xcode - Verified the PR contains only the three files related to this feature ## Implementation note The selected language is persisted in the app domain through the `AppleLanguages` preference and takes effect on the next launch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror added the

pull-request

label

2026-10-02 22:09:50 -06:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

github-starred/MonitorControl#1330

No description provided.

Rows
Columns