[PR #1891] [MERGED] Stop inactive custom shortcuts from capturing keys #1323

New issue

Closed

opened 2026-10-02 22:09:47 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-10-02 22:09:47 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/1891
Author: @EhsanAzish80
Created: 8/11/2026
Status: ✅ Merged
Merged: 8/11/2026
Merged by: @waydabber

Base: main ← Head: fix/1723-disable-inactive-shortcuts

📝 Commits (1)

8e3ac7c Disable inactive custom keyboard shortcuts

📊 Changes

2 files changed (+36 additions, -0 deletions)

View changed files

📝 MonitorControl/Support/AppDelegate.swift (+1 -0)
📝 MonitorControl/Support/KeyboardShortcutsManager.swift (+35 -0)

📄 Description

Closes #1723

Summary

synchronize custom shortcut registrations with the selected brightness and volume keyboard modes
unregister inactive shortcuts without clearing the user’s saved bindings
preserve shared key combinations needed by an active shortcut group
ignore callbacks from inactive shortcut groups

Testing

built the complete macOS app successfully with xcodebuild
tested using an isolated preferences domain and an instrumented KeyboardShortcuts 1.6.0 checkout
verified that a saved custom shortcut is unregistered in media-key mode
verified that the same shortcut remains registered in custom-shortcut mode

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/1891 **Author:** [@EhsanAzish80](https://github.com/EhsanAzish80) **Created:** 8/11/2026 **Status:** ✅ Merged **Merged:** 8/11/2026 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `main` ← **Head:** `fix/1723-disable-inactive-shortcuts` --- ### 📝 Commits (1) - [`8e3ac7c`](https://github.com/MonitorControl/MonitorControl/commit/8e3ac7cc5228ce3d6b2bb188ca2238b212ab2c98) Disable inactive custom keyboard shortcuts ### 📊 Changes **2 files changed** (+36 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Support/AppDelegate.swift` (+1 -0) 📝 `MonitorControl/Support/KeyboardShortcutsManager.swift` (+35 -0) </details> ### 📄 Description Closes #1723 ## Summary - synchronize custom shortcut registrations with the selected brightness and volume keyboard modes - unregister inactive shortcuts without clearing the user’s saved bindings - preserve shared key combinations needed by an active shortcut group - ignore callbacks from inactive shortcut groups ## Testing - built the complete macOS app successfully with `xcodebuild` - tested using an isolated preferences domain and an instrumented KeyboardShortcuts 1.6.0 checkout - verified that a saved custom shortcut is unregistered in media-key mode - verified that the same shortcut remains registered in custom-shortcut mode --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-10-02 22:09:47 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

github-starred/MonitorControl#1323

No description provided.

Rows
Columns