[PR #1859] [CLOSED] Feature/macos26 brightness hud #1293

New issue

Closed

opened 2026-05-05 07:10:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:10:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/1859
Author: @Darkroom4364
Created: 4/15/2026
Status: ❌ Closed

Base: main ← Head: feature/macos26-brightness-hud

📝 Commits (2)

191b8e3 feat: custom brightness HUD for macOS 26+
e79c47c fix: guard window race in fade completion, fix label clipping

📊 Changes

3 files changed (+130 additions, -0 deletions)

View changed files

📝 MonitorControl.xcodeproj/project.pbxproj (+4 -0)
➕ MonitorControl/Support/BrightnessHUDController.swift (+122 -0)
📝 MonitorControl/Support/OSDUtils.swift (+4 -0)

📄 Description

This pull request introduces a new custom brightness HUD overlay for macOS 15 (Sonoma) and above, replacing the system OSD for brightness changes on supported systems. The main change is the addition of the BrightnessHUDController, which displays a modern, animated heads-up display when brightness is adjusted. The implementation is modular and only activates on macOS 15 or newer, maintaining the existing behavior on older versions.

Key changes:

Feature Addition: Custom Brightness HUD

Added new file BrightnessHUDController.swift implementing a custom heads-up display for brightness changes, including a controller and a visual effect view for the overlay. The HUD shows the current brightness as a percentage with a progress bar and icon, animates its appearance and disappearance, and is managed per display.
Registered BrightnessHUDController.swift in the Xcode project file, adding it to the project group and build sources. [1] [2] [3] [4]

Integration with Existing OSD Logic

Updated OSDUtils.swift to use the new BrightnessHUDController for brightness commands on macOS 15 and above, falling back to the legacy OSD otherwise.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/1859 **Author:** [@Darkroom4364](https://github.com/Darkroom4364) **Created:** 4/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/macos26-brightness-hud` --- ### 📝 Commits (2) - [`191b8e3`](https://github.com/MonitorControl/MonitorControl/commit/191b8e3249a98335fba20bcced0f00981a39919e) feat: custom brightness HUD for macOS 26+ - [`e79c47c`](https://github.com/MonitorControl/MonitorControl/commit/e79c47c5054bac04019a6d65499c29c9cf9e2eab) fix: guard window race in fade completion, fix label clipping ### 📊 Changes **3 files changed** (+130 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl.xcodeproj/project.pbxproj` (+4 -0) ➕ `MonitorControl/Support/BrightnessHUDController.swift` (+122 -0) 📝 `MonitorControl/Support/OSDUtils.swift` (+4 -0) </details> ### 📄 Description This pull request introduces a new custom brightness HUD overlay for macOS 15 (Sonoma) and above, replacing the system OSD for brightness changes on supported systems. The main change is the addition of the `BrightnessHUDController`, which displays a modern, animated heads-up display when brightness is adjusted. The implementation is modular and only activates on macOS 15 or newer, maintaining the existing behavior on older versions. Key changes: **Feature Addition: Custom Brightness HUD** * Added new file `BrightnessHUDController.swift` implementing a custom heads-up display for brightness changes, including a controller and a visual effect view for the overlay. The HUD shows the current brightness as a percentage with a progress bar and icon, animates its appearance and disappearance, and is managed per display. * Registered `BrightnessHUDController.swift` in the Xcode project file, adding it to the project group and build sources. [[1]](diffhunk://#diff-789ccc1b84e12850b9ead0253211893b9eec9a9723a99431079a2c69ec5c7a55R185) [[2]](diffhunk://#diff-789ccc1b84e12850b9ead0253211893b9eec9a9723a99431079a2c69ec5c7a55R322) [[3]](diffhunk://#diff-789ccc1b84e12850b9ead0253211893b9eec9a9723a99431079a2c69ec5c7a55R61) [[4]](diffhunk://#diff-789ccc1b84e12850b9ead0253211893b9eec9a9723a99431079a2c69ec5c7a55R635) **Integration with Existing OSD Logic** * Updated `OSDUtils.swift` to use the new `BrightnessHUDController` for brightness commands on macOS 15 and above, falling back to the legacy OSD otherwise. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>