[PR #1846] Add "Standard keys (force capture)" option to volume control dropdown #1292

New issue

Open

opened 2026-05-05 07:10:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:10:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/1846
Author: @shuntagami
Created: 3/22/2026
Status: 🔄 Open

Base: main ← Head: feat/force-standard-volume-media-keys

📝 Commits (4)

fa5a345 Add opt-in override for standard volume media keys.
7081f54 Add Keyboard preference toggle for forced volume key capture.
f41b3b9 Adjust keyboard settings layout for forced volume key capture.
622cfb4 Refactor force-capture into a dropdown option instead of a separate checkbox

📊 Changes

4 files changed (+8 additions, -3 deletions)

View changed files

📝 MonitorControl/Enums/PrefKey.swift (+1 -0)
📝 MonitorControl/Support/MediaKeyTapManager.swift (+3 -3)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+1 -0)
📝 MonitorControl/UI/en.lproj/Main.strings (+3 -0)

📄 Description

Summary

Add a new KeyboardVolume.mediaForce enum case (tag=4) as a "Standard keys (force capture)" option in the existing Volume control dropdown
When selected, MonitorControl always captures standard volume/mute media keys — even when the default audio output device supports native macOS volume control
Default behavior remains unchanged: the existing "Standard keyboard volume and mute keys" option still disengages when macOS can control volume natively

Test plan

Select "Standard keyboard volume and mute keys" (default), use an output device with native macOS volume control, and verify volume keys are handled by macOS (not MonitorControl)
Select "Standard keys (force capture)" and verify volume keys are always captured by MonitorControl regardless of audio device
Select "Custom keyboard shortcuts" and verify custom shortcuts work as before
Select "Both standard and custom shortcuts" and verify both work
Select "Disable keyboard" and verify no keys are captured

Screen Shot

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/1846 **Author:** [@shuntagami](https://github.com/shuntagami) **Created:** 3/22/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/force-standard-volume-media-keys` --- ### 📝 Commits (4) - [`fa5a345`](https://github.com/MonitorControl/MonitorControl/commit/fa5a345b040365e7cd0a20094bfbf96722d730d1) Add opt-in override for standard volume media keys. - [`7081f54`](https://github.com/MonitorControl/MonitorControl/commit/7081f54e3e66677a3523e303cfb5b0016e6ada22) Add Keyboard preference toggle for forced volume key capture. - [`f41b3b9`](https://github.com/MonitorControl/MonitorControl/commit/f41b3b966a3497a6bd31c6686afcbe49d50fa8cb) Adjust keyboard settings layout for forced volume key capture. - [`622cfb4`](https://github.com/MonitorControl/MonitorControl/commit/622cfb481b977b0fbae4531e312cdfd222d1b558) Refactor force-capture into a dropdown option instead of a separate checkbox ### 📊 Changes **4 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Enums/PrefKey.swift` (+1 -0) 📝 `MonitorControl/Support/MediaKeyTapManager.swift` (+3 -3) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+1 -0) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+3 -0) </details> ### 📄 Description ## Summary - Add a new `KeyboardVolume.mediaForce` enum case (tag=4) as a "Standard keys (force capture)" option in the existing Volume control dropdown - When selected, MonitorControl always captures standard volume/mute media keys — even when the default audio output device supports native macOS volume control - Default behavior remains unchanged: the existing "Standard keyboard volume and mute keys" option still disengages when macOS can control volume natively ## Test plan - [ ] Select "Standard keyboard volume and mute keys" (default), use an output device with native macOS volume control, and verify volume keys are handled by macOS (not MonitorControl) - [ ] Select "Standard keys (force capture)" and verify volume keys are always captured by MonitorControl regardless of audio device - [ ] Select "Custom keyboard shortcuts" and verify custom shortcuts work as before - [ ] Select "Both standard and custom shortcuts" and verify both work - [ ] Select "Disable keyboard" and verify no keys are captured ## Screen Shot <img width="2884" height="2216" alt="CleanShot 2026-03-22 at 18 10 57@2x" src="https://github.com/user-attachments/assets/57ce4cbd-38f4-4d57-ac4a-016bc5e52b1c" /> 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>