[PR #1817] [MERGED] feat: support "only when external display show menu bar icon" option #1287

New issue

Closed

opened 2026-05-05 07:10:12 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:10:12 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/1817
Author: @Yifei0727
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/16/2025
Merged by: @waydabber

Base: main ← Head: main

📝 Commits (4)

8d592ff feat(Enums): Add externalOnly option to MenuIcon enum
3c9c2e4 feat(MenuHandler): Enhance menu icon visibility logic for new option with external displays
430e42f feat(storyboard): Add menu option for app config
db41acd feat(i18n): Add menu item for external display presence across multiple languages

📊 Changes

22 files changed (+72 additions, -1 deletions)

View changed files

📝 MonitorControl/Enums/PrefKey.swift (+1 -0)
📝 MonitorControl/Support/MenuHandler.swift (+13 -1)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+1 -0)
📝 MonitorControl/UI/cs.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/de.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/en.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/es.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/fr.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/hi.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/hu.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/it.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/ja.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/ko.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/nl.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/pl.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/pt-BR.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/pt-PT.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/ru.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/sk.lproj/Main.strings (+3 -0)
📝 MonitorControl/UI/tr.lproj/Main.strings (+3 -0)

...and 2 more files

📄 Description

commits for #1814 support "only when external display show menu bar icon" option

changes:

[x] add an option enum for new select "when external ..."
[x] impl event handler for this option to select show or hide icon
[x] i18n for this option title(by copilot ai & gemini ai)

test on my macbook16(2021,macos 26.1)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/1817 **Author:** [@Yifei0727](https://github.com/Yifei0727) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/16/2025 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`8d592ff`](https://github.com/MonitorControl/MonitorControl/commit/8d592ff12cd8c3c4c77d7aaa3ba9a9b0f576a1a6) feat(Enums): Add externalOnly option to MenuIcon enum - [`3c9c2e4`](https://github.com/MonitorControl/MonitorControl/commit/3c9c2e42ed5fd0ef61e2c6787ef2e926be8b7563) feat(MenuHandler): Enhance menu icon visibility logic for new option with external displays - [`430e42f`](https://github.com/MonitorControl/MonitorControl/commit/430e42f4a9a8aba9b42433563f2fb443bef4dfbf) feat(storyboard): Add menu option for app config - [`db41acd`](https://github.com/MonitorControl/MonitorControl/commit/db41acde4e9493dc883d465db6600bfa3dfa5ede) feat(i18n): Add menu item for external display presence across multiple languages ### 📊 Changes **22 files changed** (+72 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Enums/PrefKey.swift` (+1 -0) 📝 `MonitorControl/Support/MenuHandler.swift` (+13 -1) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+1 -0) 📝 `MonitorControl/UI/cs.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/de.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/es.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/fr.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/hi.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/hu.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/it.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/ja.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/ko.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/nl.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/pl.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/pt-BR.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/pt-PT.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/ru.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/sk.lproj/Main.strings` (+3 -0) 📝 `MonitorControl/UI/tr.lproj/Main.strings` (+3 -0) _...and 2 more files_ </details> ### 📄 Description commits for #1814 support "only when external display show menu bar icon" option changes: [x] add an option enum for new select "when external ..." [x] impl event handler for this option to select show or hide icon [x] i18n for this option title(by copilot ai & gemini ai) test on my macbook16(2021,macos 26.1) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>