mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[PR #1465] [CLOSED] Send "Unmute" on volume change #1262
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#1262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/MonitorControl/MonitorControl/pull/1465
Author: @zv0n
Created: 11/8/2023
Status: ❌ Closed
Base:
main← Head:unmute-when-changing-audio📝 Commits (4)
ffa242bSend unmute on volume change308b96cAdd UI element to enable sending unmute after volume changee63bb91Add English and Czech translation for new UI element4aa5ce5Update BundleVersion📊 Changes
9 files changed (+219 additions, -172 deletions)
View changed files
📝
MonitorControl/Enums/PrefKey.swift(+3 -0)📝
MonitorControl/Info.plist(+1 -1)📝
MonitorControl/Model/OtherDisplay.swift(+4 -0)📝
MonitorControl/Support/SliderHandler.swift(+4 -0)📝
MonitorControl/UI/Base.lproj/Main.storyboard(+183 -171)📝
MonitorControl/UI/cs.lproj/Main.strings(+3 -0)📝
MonitorControl/UI/en.lproj/Main.strings(+3 -0)📝
MonitorControl/View Controllers/Preferences/DisplaysPrefsCellView.swift(+14 -0)📝
MonitorControl/View Controllers/Preferences/DisplaysPrefsViewController.swift(+4 -0)📄 Description
My monitor requires sending "Unmute" command over DDC after a volume change for that change to take effect.
I've added an option into the UI to enable this behavior.
Might fix problems for some people in this issue - https://github.com/MonitorControl/MonitorControl/issues/1369
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.